Merge bitcoin-core/gui#331: Make RPC console welcome message translation-friendly

0f3d955a38fe59a4e8cc4bf9f4442e6e1fd8bcbb qt: Make RPC console welcome message translation-friendly (Hennadii Stepanov)

Pull request description:

  The best practice is do not split a translatable multi-line message into single lines. This helps translators to follow the context.

ACKs for top commit:
  jarolrod:
    re-ACK 0f3d955a38fe59a4e8cc4bf9f4442e6e1fd8bcbb

Tree-SHA512: 30911ff3a972a7787804bb8b27d0b77bfff15939bb478c199261866bfb55d9acd12ab4d44b8b9fc1d4898222cabc4007cc897f9b65728924d121f31e914c44ac
This commit is contained in:
Hennadii Stepanov 2021-05-31 23:41:04 +03:00 committed by Konstantin Akimov
parent 69a1305978
commit 19310646e0
No known key found for this signature in database
GPG Key ID: 2176C4A5D01EA524

View File

@ -936,23 +936,29 @@ void RPCConsole::clear(bool keep_prompt)
).arg(consoleFontSize) ).arg(consoleFontSize)
); );
message(CMD_REPLY, static const QString welcome_message =
tr("Welcome to the %1 RPC console.").arg(PACKAGE_NAME) + /*: RPC console welcome message.
"<br>" + Placeholders %7 and %8 are style tags for the warning content, and
tr("Use up and down arrows to navigate history, and %1 to clear screen.") they are not space separated from the rest of the text intentionally. */
.arg("<b>" + ui->clearButton->shortcut().toString(QKeySequence::NativeText) + "</b>") + tr("Welcome to the %1 RPC console.\n"
"<br>" + "Use up and down arrows to navigate history, and %2 to clear screen.\n"
tr("Use %1 and %2 to increase or decrease the font size.") "Use %3 and %4 to increase or decrease the font size.\n"
.arg("<b>" + ui->fontBiggerButton->shortcut().toString(QKeySequence::NativeText) + "</b>") "Type %5 for an overview of available commands.\n"
.arg("<b>" + ui->fontSmallerButton->shortcut().toString(QKeySequence::NativeText) + "</b>") + "For more information on using this console, type %6.\n"
"<br>" + "\n"
tr("Type %1 for an overview of available commands.").arg("<b>help</b>") + "%7WARNING: Scammers have been active, telling users to type"
"<br>" + " commands here, stealing their wallet contents. Do not use this console"
tr("For more information on using this console type %1.").arg("<b>help-console</b>") + " without fully understanding the ramifications of a command.%8")
"<br><span class=\"secwarning\"><br>" + .arg(PACKAGE_NAME,
tr("WARNING: Scammers have been active, telling users to type commands here, stealing their wallet contents. Do not use this console without fully understanding the ramifications of a command.") + "<b>" + ui->clearButton->shortcut().toString(QKeySequence::NativeText) + "</b>",
"</span>", "<b>" + ui->fontBiggerButton->shortcut().toString(QKeySequence::NativeText) + "</b>",
true); "<b>" + ui->fontSmallerButton->shortcut().toString(QKeySequence::NativeText) + "</b>",
"<b>help</b>",
"<b>help-console</b>",
"<span class=\"secwarning\">",
"<span>");
message(CMD_REPLY, welcome_message, true);
} }
void RPCConsole::keyPressEvent(QKeyEvent *event) void RPCConsole::keyPressEvent(QKeyEvent *event)