sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-27 13:03:17 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

test: Replace remaining sprintf with snprintf

Browse Source 
Use of `sprintf` is seen as a red flag as many of its uses are insecure.
OpenBSD warns about it while compiling, and some modern platforms, e.g.
[cloudlibc from cloudabi](https://github.com/NuxiNL/cloudlibc) don't
even provide it anymore.

Although our uses of these functions are secure, it can't hurt to
replace them anyway. There are only 3 occurences left, all in the
tests.
This commit is contained in:
Wladimir J. van der Laan 2017-02-26 21:08:26 +01:00
parent 0a177148e7
commit 19cafc6239
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/dbwrapper_tests.cpp
View File

@ -277,7 +277,7 @@ BOOST_AUTO_TEST_CASE(iterator_string_ordering)
CDBWrapper dbw(ph, (1 << 20), true, false, false); CDBWrapper dbw(ph, (1 << 20), true, false, false);
for (int x=0x00; x<10; ++x) { for (int x=0x00; x<10; ++x) {
for (int y = 0; y < 10; y++) { for (int y = 0; y < 10; y++) {
sprintf(buf, "%d", x); snprintf(buf, sizeof(buf), "%d", x);
StringContentsSerializer key(buf); StringContentsSerializer key(buf);
for (int z = 0; z < y; z++) for (int z = 0; z < y; z++)
key += key; key += key;
@ -293,12 +293,12 @@ BOOST_AUTO_TEST_CASE(iterator_string_ordering)
seek_start = 0; seek_start = 0;
else else
seek_start = 5; seek_start = 5;
sprintf(buf, "%d", seek_start); snprintf(buf, sizeof(buf), "%d", seek_start);
StringContentsSerializer seek_key(buf); StringContentsSerializer seek_key(buf);
it->Seek(seek_key); it->Seek(seek_key);
for (int x=seek_start; x<10; ++x) { for (int x=seek_start; x<10; ++x) {
for (int y = 0; y < 10; y++) { for (int y = 0; y < 10; y++) {
sprintf(buf, "%d", x); snprintf(buf, sizeof(buf), "%d", x);
std::string exp_key(buf); std::string exp_key(buf);
for (int z = 0; z < y; z++) for (int z = 0; z < y; z++)
exp_key += exp_key; exp_key += exp_key;