Merge #5950: refactor: RecursiveMutex -> Mutex for cs_mnauth

7cc305f1b2 refactor: RecursiveMutex -> Mutex for cs_mnauth (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  Avoid using recursive mutexes where a non-recursive one does the job

  ## What was done?
  RecursiveMutex -> Mutex

  ## How Has This Been Tested?
  Built

  ## Breaking Changes
  None

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: 7c624263a1aa7aca61b12598a24fc570beca8a240ef66c5a80c86b410487a1450b3c3f31394d773c5a6041abe244708007a115f29212746d549268d376a267e1
This commit is contained in:
pasta 2024-03-23 09:56:49 -05:00
commit 1af51b2004
No known key found for this signature in database
GPG Key ID: 52527BEDABE87984

View File

@ -711,7 +711,7 @@ private:
const bool m_inbound_onion{false};
// Challenge sent in VERSION to be answered with MNAUTH (only happens between MNs)
mutable RecursiveMutex cs_mnauth;
mutable Mutex cs_mnauth;
uint256 sentMNAuthChallenge GUARDED_BY(cs_mnauth);
uint256 receivedMNAuthChallenge GUARDED_BY(cs_mnauth);
uint256 verifiedProRegTxHash GUARDED_BY(cs_mnauth);