mirror of
https://github.com/dashpay/dash.git
synced 2024-12-24 11:32:46 +01:00
Merge bitcoin/bitcoin#25888: refactor: use strprintf
for creating unknown-service-flag string
706c8e096978b694fb56dee9e8ed8f55373ad5a0 refactor: use `strprintf` for creating unknown-service-flag string (Sebastian Falbesoner)
Pull request description:
No need to use a stringstream here. The trivial change can be verified by running the functional test `rpc_net.py`:
c73c8d53fe/test/functional/rpc_net.py (L181-L184)
As far as I could tell, this is the only instace left where we used `std::ostringstream` for the creation of simple strings (in `FormatSubVersion` using a stream makes sense since the number of placeholders is not constant).
ACKs for top commit:
kristapsk:
ACK 706c8e096978b694fb56dee9e8ed8f55373ad5a0
Tree-SHA512: 069cea29aef03996ae16a0dc3ed87b1b2cf2ab0bf5987c225b10da12d0f4b62b7c3faf3a169c0b912eb2ad60c6ea0a09a622be7eaadad78cee0463ef4ffc0e19
This commit is contained in:
parent
1526885baf
commit
1c678a1b62
@ -349,12 +349,7 @@ static std::string serviceFlagToStr(size_t bit)
|
||||
// Not using default, so we get warned when a case is missing
|
||||
}
|
||||
|
||||
std::ostringstream stream;
|
||||
stream.imbue(std::locale::classic());
|
||||
stream << "UNKNOWN[";
|
||||
stream << "2^" << bit;
|
||||
stream << "]";
|
||||
return stream.str();
|
||||
return strprintf("UNKNOWN[2^%u]", bit);
|
||||
}
|
||||
|
||||
std::vector<std::string> serviceFlagsToStr(uint64_t flags)
|
||||
|
Loading…
Reference in New Issue
Block a user