sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: rename hdChain to m_hd_chain

Browse Source 
This commit helps to unify our implementation with bitcoin which has
the similar refactoring in bitcoin#17681 but we DNM it due to difference in
sethdseed behavior: we do not replace seed ever
This commit is contained in:
Konstantin Akimov 2024-04-26 01:01:37 +07:00
parent 266aefc544
commit 2c0d5b7c71
No known key found for this signature in database
GPG Key ID: 2176C4A5D01EA524
2 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/wallet/scriptpubkeyman.cpp
View File

@ -218,14 +218,14 @@ bool LegacyScriptPubKeyMan::CheckDecryptionKey(const CKeyingMaterial& master_key
if (keyFail) { if (keyFail) {
return false; return false;
} }
if (!keyPass && !accept_no_keys && (hdChain.IsNull() || !hdChain.IsNull() && !hdChain.IsCrypted())) { if (!keyPass && !accept_no_keys && (m_hd_chain.IsNull() || !m_hd_chain.IsNull() && !m_hd_chain.IsCrypted())) {
return false; return false;
} }
if(!hdChain.IsNull() && !hdChain.IsCrypted()) { if(!m_hd_chain.IsNull() && !m_hd_chain.IsCrypted()) {
// try to decrypt seed and make sure it matches // try to decrypt seed and make sure it matches
CHDChain hdChainTmp; CHDChain hdChainTmp;
if (!DecryptHDChain(master_key, hdChainTmp) || (hdChain.GetID() != hdChainTmp.GetSeedHash())) { if (!DecryptHDChain(master_key, hdChainTmp) || (m_hd_chain.GetID() != hdChainTmp.GetSeedHash())) {
return false; return false;
} }
} }
@ -267,8 +267,8 @@ bool LegacyScriptPubKeyMan::Encrypt(const CKeyingMaterial& master_key, WalletBat
} }
if (!hdChainCurrent.IsNull()) { if (!hdChainCurrent.IsNull()) {
assert(EncryptHDChain(master_key, hdChain)); assert(EncryptHDChain(master_key, m_hd_chain));
assert(SetHDChain(hdChain)); assert(SetHDChain(m_hd_chain));
CHDChain hdChainCrypted; CHDChain hdChainCrypted;
assert(GetHDChain(hdChainCrypted)); assert(GetHDChain(hdChainCrypted));
@ -539,40 +539,40 @@ bool LegacyScriptPubKeyMan::DecryptHDChain(const CKeyingMaterial& vMasterKeyIn,
if (!m_storage.HasEncryptionKeys()) if (!m_storage.HasEncryptionKeys())
return true; return true;
if (hdChain.IsNull()) if (m_hd_chain.IsNull())
return false; return false;
if (!hdChain.IsCrypted()) if (!m_hd_chain.IsCrypted())
return false; return false;
SecureVector vchSecureSeed; SecureVector vchSecureSeed;
SecureVector vchSecureCryptedSeed = hdChain.GetSeed(); SecureVector vchSecureCryptedSeed = m_hd_chain.GetSeed();
std::vector<unsigned char> vchCryptedSeed(vchSecureCryptedSeed.begin(), vchSecureCryptedSeed.end()); std::vector<unsigned char> vchCryptedSeed(vchSecureCryptedSeed.begin(), vchSecureCryptedSeed.end());
if (!DecryptSecret(vMasterKeyIn, vchCryptedSeed, hdChain.GetID(), vchSecureSeed)) if (!DecryptSecret(vMasterKeyIn, vchCryptedSeed, m_hd_chain.GetID(), vchSecureSeed))
return false; return false;
hdChainRet = hdChain; hdChainRet = m_hd_chain;
if (!hdChainRet.SetSeed(vchSecureSeed, false)) if (!hdChainRet.SetSeed(vchSecureSeed, false))
return false; return false;
// hash of decrypted seed must match chain id // hash of decrypted seed must match chain id
if (hdChainRet.GetSeedHash() != hdChain.GetID()) if (hdChainRet.GetSeedHash() != m_hd_chain.GetID())
return false; return false;
SecureVector vchSecureCryptedMnemonic; SecureVector vchSecureCryptedMnemonic;
SecureVector vchSecureCryptedMnemonicPassphrase; SecureVector vchSecureCryptedMnemonicPassphrase;
// it's ok to have no mnemonic if wallet was initialized via hdseed // it's ok to have no mnemonic if wallet was initialized via hdseed
if (hdChain.GetMnemonic(vchSecureCryptedMnemonic, vchSecureCryptedMnemonicPassphrase)) { if (m_hd_chain.GetMnemonic(vchSecureCryptedMnemonic, vchSecureCryptedMnemonicPassphrase)) {
SecureVector vchSecureMnemonic; SecureVector vchSecureMnemonic;
SecureVector vchSecureMnemonicPassphrase; SecureVector vchSecureMnemonicPassphrase;
std::vector<unsigned char> vchCryptedMnemonic(vchSecureCryptedMnemonic.begin(), vchSecureCryptedMnemonic.end()); std::vector<unsigned char> vchCryptedMnemonic(vchSecureCryptedMnemonic.begin(), vchSecureCryptedMnemonic.end());
std::vector<unsigned char> vchCryptedMnemonicPassphrase(vchSecureCryptedMnemonicPassphrase.begin(), vchSecureCryptedMnemonicPassphrase.end()); std::vector<unsigned char> vchCryptedMnemonicPassphrase(vchSecureCryptedMnemonicPassphrase.begin(), vchSecureCryptedMnemonicPassphrase.end());
if (!vchCryptedMnemonic.empty() && !DecryptSecret(vMasterKeyIn, vchCryptedMnemonic, hdChain.GetID(), vchSecureMnemonic)) if (!vchCryptedMnemonic.empty() && !DecryptSecret(vMasterKeyIn, vchCryptedMnemonic, m_hd_chain.GetID(), vchSecureMnemonic))
return false; return false;
if (!vchCryptedMnemonicPassphrase.empty() && !DecryptSecret(vMasterKeyIn, vchCryptedMnemonicPassphrase, hdChain.GetID(), vchSecureMnemonicPassphrase)) if (!vchCryptedMnemonicPassphrase.empty() && !DecryptSecret(vMasterKeyIn, vchCryptedMnemonicPassphrase, m_hd_chain.GetID(), vchSecureMnemonicPassphrase))
return false; return false;
if (!hdChainRet.SetMnemonic(vchSecureMnemonic, vchSecureMnemonicPassphrase, false)) if (!hdChainRet.SetMnemonic(vchSecureMnemonic, vchSecureMnemonicPassphrase, false))
@ -1096,7 +1096,7 @@ bool LegacyScriptPubKeyMan::SetHDChain(const CHDChain& chain)
if (m_storage.HasEncryptionKeys() != chain.IsCrypted()) return false; if (m_storage.HasEncryptionKeys() != chain.IsCrypted()) return false;
hdChain = chain; m_hd_chain = chain;
return true; return true;
} }
@ -1758,8 +1758,8 @@ std::set<CKeyID> LegacyScriptPubKeyMan::GetKeys() const
bool LegacyScriptPubKeyMan::GetHDChain(CHDChain& hdChainRet) const bool LegacyScriptPubKeyMan::GetHDChain(CHDChain& hdChainRet) const
{ {
LOCK(cs_KeyStore); LOCK(cs_KeyStore);
hdChainRet = hdChain; hdChainRet = m_hd_chain;
return !hdChain.IsNull(); return !m_hd_chain.IsNull();
} }
void LegacyScriptPubKeyMan::SetInternal(bool internal) {} void LegacyScriptPubKeyMan::SetInternal(bool internal) {}

2
src/wallet/scriptpubkeyman.h
View File

@ -286,7 +286,7 @@ private:
bool SetHDChain(const CHDChain& chain); bool SetHDChain(const CHDChain& chain);
/* the HD chain data model (external chain counters) */ /* the HD chain data model (external chain counters) */
CHDChain hdChain GUARDED_BY(cs_KeyStore); CHDChain m_hd_chain GUARDED_BY(cs_KeyStore);
/* HD derive new child key (on internal or external chain) */ /* HD derive new child key (on internal or external chain) */
void DeriveNewChildKey(WalletBatch& batch, CKeyMetadata& metadata, CKey& secretRet, uint32_t nAccountIndex, bool fInternal /*= false*/) EXCLUSIVE_LOCKS_REQUIRED(cs_KeyStore); void DeriveNewChildKey(WalletBatch& batch, CKeyMetadata& metadata, CKey& secretRet, uint32_t nAccountIndex, bool fInternal /*= false*/) EXCLUSIVE_LOCKS_REQUIRED(cs_KeyStore);