From 2f63322cdc1ec003ea5e0a12a84dc8327bd645fc Mon Sep 17 00:00:00 2001 From: Pasta Date: Wed, 15 May 2019 21:21:54 -0500 Subject: [PATCH] dashify "Finding reviewers" section to be more relevant Signed-off-by: Pasta --- CONTRIBUTING.md | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c9b77c54cc..e8ce37f967 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -227,11 +227,10 @@ a worthwhile change based on the judgement of the maintainers. ### Finding Reviewers -As most reviewers are themselves developers with their own projects, the review -process can be quite lengthy, and some amount of patience is required. If you find -that you've been waiting for a pull request to be given attention for several -months, there may be a number of reasons for this, some of which you can do something -about: +The review process is normally fairly responsive on the Dash Core repository, however +this might not always be the case. If you find that you've been waiting +for a pull request to be given attention for several months, there may be a number +of reasons for this, some of which you can do something about: - It may be because of a feature freeze due to an upcoming release. During this time, only bug fixes are taken into consideration. If your pull request is a new feature, @@ -243,15 +242,15 @@ about: that personally, though! Instead, take another critical look at what you are suggesting and see if it: changes too much, is too broad, doesn't adhere to the [developer notes](doc/developer-notes.md), is dangerous or insecure, is messily written, etc. - Identify and address any of the issues you find. Then ask e.g. on IRC if someone could give - their opinion on the concept itself. + Identify and address any of the issues you find. Then ask e.g. on the forum or on a community + discord if someone could give their opinion on the concept itself. - It may be because your code is too complex for all but a few people. And those people may not have realized your pull request even exists. A great way to find people who are qualified and care about the code you are touching is the [Git Blame feature](https://help.github.com/articles/tracing-changes-in-a-file/). Simply find the person touching the code you are touching before you and see if you can find them and give them a nudge. Don't be incessant about the nudging though. - - Finally, if all else fails, ask on IRC or elsewhere for someone to give your pull request + - Finally, if all else fails, ask on discord or elsewhere for someone to give your pull request a look. If you think you've been waiting an unreasonably long amount of time (month+) for no particular reason (few lines changed, etc), this is totally fine. Try to return the favor when someone else is asking for feedback on their code, and universe balances out.