From 2f83b6ae252affb1db5f84f70402552a608ab7c2 Mon Sep 17 00:00:00 2001 From: dustinface <35775977+xdustinface@users.noreply.github.com> Date: Sun, 9 Aug 2020 23:36:52 +0200 Subject: [PATCH] llmq: Fix spork check in CSigSharesManager::ForceReAnnouncement (#3650) It seems like the idea here was to avoid announcing already available sigshares for a signhash to everyone if concentrated recovery is enabled. But by returning there if `IsAllMembersConnectedEnabled` equals to `false` we disable the re-announcements prior to the spork activation, where we want to still have them and re-enable if the spork is enabled where we don't want to have them. --- src/llmq/quorums_signing_shares.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/llmq/quorums_signing_shares.cpp b/src/llmq/quorums_signing_shares.cpp index d02e55df0b..356b1c0490 100644 --- a/src/llmq/quorums_signing_shares.cpp +++ b/src/llmq/quorums_signing_shares.cpp @@ -1607,7 +1607,7 @@ void CSigSharesManager::Sign(const CQuorumCPtr& quorum, const uint256& id, const // causes all known sigShares to be re-announced void CSigSharesManager::ForceReAnnouncement(const CQuorumCPtr& quorum, Consensus::LLMQType llmqType, const uint256& id, const uint256& msgHash) { - if (!CLLMQUtils::IsAllMembersConnectedEnabled(llmqType)) { + if (CLLMQUtils::IsAllMembersConnectedEnabled(llmqType)) { return; }