sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-26 12:32:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #8466: [Trivial] Do not shadow variables in networking code

Browse Source 
b7c349d Do not shadow variables in networking code (Pavel Janík)
This commit is contained in:
Wladimir J. van der Laan 2016-09-02 12:32:49 +02:00 committed by Alexander Block
parent 414272af93
commit 313cfb09da
4 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/net.h
View File

@ -850,21 +850,21 @@ public:
void AddAddressKnown(const CAddress& addr) void AddAddressKnown(const CAddress& _addr)
{ {
addrKnown.insert(addr.GetKey()); addrKnown.insert(_addr.GetKey());
} }
void PushAddress(const CAddress& addr) void PushAddress(const CAddress& _addr)
{ {
// Known checking here is only to save space from duplicates. // Known checking here is only to save space from duplicates.
// SendMessages will filter it again for knowns that were added // SendMessages will filter it again for knowns that were added
// after addresses were pushed. // after addresses were pushed.
if (addr.IsValid() && !addrKnown.contains(addr.GetKey())) { if (_addr.IsValid() && !addrKnown.contains(_addr.GetKey())) {
if (vAddrToSend.size() >= MAX_ADDR_TO_SEND) { if (vAddrToSend.size() >= MAX_ADDR_TO_SEND) {
vAddrToSend[insecure_rand() % vAddrToSend.size()] = addr; vAddrToSend[insecure_rand() % vAddrToSend.size()] = _addr;
} else { } else {
vAddrToSend.push_back(addr); vAddrToSend.push_back(_addr);
} }
} }
} }

4
src/netaddress.cpp
View File

@ -200,8 +200,8 @@ bool CNetAddr::IsValid() const
return false; return false;
// unspecified IPv6 address (::/128) // unspecified IPv6 address (::/128)
unsigned char ipNone[16] = {}; unsigned char ipNone6[16] = {};
if (memcmp(ip, ipNone, 16) == 0) if (memcmp(ip, ipNone6, 16) == 0)
return false; return false;
// documentation IPv6 address // documentation IPv6 address

6
src/netbase.cpp
View File

@ -627,8 +627,8 @@ bool ConnectSocketByName(CService &addr, SOCKET& hSocketRet, const char *pszDest
SplitHostPort(std::string(pszDest), port, strDest); SplitHostPort(std::string(pszDest), port, strDest);
proxyType nameProxy; proxyType proxy;
GetNameProxy(nameProxy); GetNameProxy(proxy);
std::vector<CService> addrResolved; std::vector<CService> addrResolved;
if (Lookup(strDest.c_str(), addrResolved, port, fNameLookup && !HaveNameProxy(), 256)) { if (Lookup(strDest.c_str(), addrResolved, port, fNameLookup && !HaveNameProxy(), 256)) {
@ -642,7 +642,7 @@ bool ConnectSocketByName(CService &addr, SOCKET& hSocketRet, const char *pszDest
if (!HaveNameProxy()) if (!HaveNameProxy())
return false; return false;
return ConnectThroughProxy(nameProxy, strDest, port, hSocketRet, nTimeout, outProxyConnectionFailed); return ConnectThroughProxy(proxy, strDest, port, hSocketRet, nTimeout, outProxyConnectionFailed);
} }
bool LookupSubNet(const char* pszName, CSubNet& ret) bool LookupSubNet(const char* pszName, CSubNet& ret)

2
src/netbase.h
View File

@ -30,7 +30,7 @@ class proxyType
{ {
public: public:
proxyType(): randomize_credentials(false) {} proxyType(): randomize_credentials(false) {}
proxyType(const CService &proxy, bool randomize_credentials=false): proxy(proxy), randomize_credentials(randomize_credentials) {} proxyType(const CService &_proxy, bool _randomize_credentials=false): proxy(_proxy), randomize_credentials(_randomize_credentials) {}
bool IsValid() const { return proxy.IsValid(); } bool IsValid() const { return proxy.IsValid(); }