sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-24 19:42:46 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #6375: fix: devnet stuck on block 2 with crash

Browse Source 
50ea5e13f5 fix: cbtx tx as special transaction can't be retrieved before DIP0003 is activated (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Failure on devnet:

  ![image](https://github.com/user-attachments/assets/66163c3d-e818-478c-8915-48889317ecd1)

  +extra logs haven't got to screenshot:
  ```
  2024-10-31T13:19:21Z CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
  2024-10-31T13:19:21Z Posix Signal: Aborted
  ```

  Locally similar error is caught with stacktrace:

          Assertion failure:
            assertion: (tx.nType == T::SPECIALTX_TYPE)
            file: ./evo/specialtx.h, line: 33
            function: std::optional<_Tp> GetTxPayload(const TxType&, bool) [with T = CCbTx; TxType = CTransaction]
             0#: (0x5CE686FB3AB0) stacktraces.cpp:655 - __wrap___assert_fail
             1#: (0x5CE686BB9120) specialtx.h:33      - std::optional<CCbTx> GetTxPayload<CCbTx, CTransaction>(CTransaction const&, bool)
             2#: (0x5CE686BB9120) cbtx.cpp:463        - GetCoinbaseTx(CBlockIndex const*)
             3#: (0x5CE686BB916D) cbtx.cpp:470        - GetNonNullCoinbaseChainlock(CBlockIndex const*)
             4#: (0x5CE686BB92AA) optional:469        - std::_Optional_base_impl<std::pair<CBLSSignature, unsigned int>, std::_Optional_base<std::pair<CBLSSignature, unsigned int>, false, false> >::_M_is_engaged() const
             5#: (0x5CE686BB92AA) optional:986        - std::optional<std::pair<CBLSSignature, unsigned int> >::has_value() const
             6#: (0x5CE686BB92AA) cbtx.cpp:401        - CalcCbTxBestChainlock(llmq::CChainLocksHandler const&, CBlockIndex const*, unsigned int&, CBLSSignature&)
             7#: (0x5CE686D36318) miner.cpp:233       - BlockAssembler::CreateNewBlock(CScript const&)

  ## What was done?
  Added check if DIP0003 is indeed activated before retrieving Chainlock of previous block.

  ## How Has This Been Tested?
  No crash observed locally

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    light ACK 50ea5e13f5 (reindexed on mainnet and testnet with `-assumevalid` set to pre-v20 block hashes, no issues)
  PastaPastaPasta:
    utACK 50ea5e13f5

Tree-SHA512: a51c1d1b56c5d1a2effab5e6dcf76f87a52eb812ba7bafb0d0dbf2eb5172ae6513be891efeec1f8ecf71b3976b2a6e309e4a61602f5a3cc3c817f869d65a3f0d
This commit is contained in:
pasta 2024-11-02 11:40:42 -05:00
commit 396573d09c
No known key found for this signature in database
GPG Key ID: E2F3D7916E722D38
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/evo/cbtx.cpp
View File

@ -454,6 +454,11 @@ std::optional<CCbTx> GetCoinbaseTx(const CBlockIndex* pindex)
return std::nullopt;
}
// There's no CbTx before DIP0003 activation
if (!DeploymentActiveAt(*pindex, Params().GetConsensus(), Consensus::DEPLOYMENT_DIP0003)) {
return std::nullopt;
}
CBlock block;
if (!ReadBlockFromDisk(block, pindex, Params().GetConsensus())) {
return std::nullopt;