Merge bitcoin/bitcoin#21745: refactor: Add missing includes in pubkey.cpp/pubkey.h

71c824ed6cf70b39ca09e8b3962f452f69523af0 cleaned up and added missing "include" statements for pubkey.cpp and pubkey.h (William Bright)

Pull request description:

  #### Problem:
  Many symbols in the files were undefined and causing issues when I was working on building independent sections of the codebase. The hidden imports from the "secp256k1" library was a particular pain point.

  The other standard and missing includes are following best practices and will help with refactoring, build process and others.

  #### Changes:
  Clean up and declared imports/include for `pubkey.cpp` and `pubkey.h`

ACKs for top commit:
  jnewbery:
    utACK 71c824ed6c
  laanwj:
    Code review ACK 71c824ed6cf70b39ca09e8b3962f452f69523af0

Tree-SHA512: bce605cfde24d8e3be82a596cabab7a8577fec0aef7c5e6f7a56603357046d8e8dea11ac8e3dbe79600550291be7784e35c7a55ebf40b46525b8949e4bedae96
This commit is contained in:
W. J. van der Laan 2021-05-10 14:35:28 +02:00 committed by pasta
parent 1ee01c801e
commit 3b5dc9e5aa
No known key found for this signature in database
GPG Key ID: 52527BEDABE87984
2 changed files with 7 additions and 1 deletions

View File

@ -5,10 +5,16 @@
#include <pubkey.h>
#include <hash.h>
#include <secp256k1.h>
#include <secp256k1_extrakeys.h>
#include <secp256k1_ellswift.h>
#include <secp256k1_recovery.h>
#include <span.h>
#include <uint256.h>
#include <algorithm>
#include <cassert>
namespace {
struct Secp256k1SelfTester

View File

@ -12,7 +12,7 @@
#include <uint256.h>
#include <array>
#include <stdexcept>
#include <cstring>
#include <vector>
const unsigned int BIP32_EXTKEY_SIZE = 74;