Merge #6112: refactor: remove unused includes from unit tests

e65984e173 refactor: remove unused includes from unit tests (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Noticed there were some not used includes in Unit tests and removed them.

  It's not exhaustive list of unused headers, just something that was easy to spot.

  ## How Has This Been Tested?
  Just build and see that there's no build error.

  This PR also slightly reduced compilation time of project, it's measurable big changes to6-8 seconds of one CPU core faster. Tested by compiling only files that changed in single-thread:
  ```
  $ rm src/test/test_dash-blockfilter_index_tests.o src/test/test_dash-block_reward_reallocation_tests.o src/test/test_dash-denialofservice_tests.o src/test/test_dash-dynamic_activation_thresholds_tests.o src/test/test_dash-validation_block_tests.o src/test/test_dash-validation_chainstate_tests.o src/test/test_dash-validation_flush_tests.o  src/test/util/libtest_util_a-mining.o src/test/util/libtest_util_a-setup_common.o
  $ cd src/test ; time make -j1
  ```

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    utACK e65984e173
  PastaPastaPasta:
    utACK e65984e173

Tree-SHA512: 445c1515aee09e946eb73f12ca9c8064d26cd6148d2286fa079bf54806ea77af9eda890a36c8f34450791e868fbe933183bc7e507dd6e667304ccd92790bb009

src/test/block_reward_reallocation_tests.cpp

@@ -15,18 +15,12 @@
 #include <script/sign.h>
 #include <script/signingprovider.h>
 #include <script/standard.h>
-#include <spork.h>
 #include <validation.h>
 
 #include <evo/deterministicmns.h>
 #include <evo/mnhftx.h>
 #include <evo/providertx.h>
 #include <evo/specialtx.h>
-#include <governance/governance.h>
-#include <llmq/blockprocessor.h>
-#include <llmq/chainlocks.h>
-#include <llmq/context.h>
-#include <llmq/instantsend.h>
 #include <masternode/payments.h>
 #include <util/enumerate.h>
 #include <util/irange.h>

src/test/blockfilter_index_tests.cpp

@@ -5,13 +5,7 @@
 #include <blockfilter.h>
 #include <chainparams.h>
 #include <consensus/validation.h>
-#include <evo/evodb.h>
-#include <governance/governance.h>
 #include <index/blockfilterindex.h>
-#include <llmq/blockprocessor.h>
-#include <llmq/chainlocks.h>
-#include <llmq/context.h>
-#include <llmq/instantsend.h>
 #include <miner.h>
 #include <pow.h>
 #include <script/standard.h>

src/test/denialofservice_tests.cpp

@@ -6,8 +6,6 @@
 
 #include <banman.h>
 #include <chainparams.h>
-#include <evo/deterministicmns.h>
-#include <llmq/context.h>
 #include <net.h>
 #include <net_processing.h>
 #include <pubkey.h>
@@ -20,7 +18,6 @@
 #include <util/system.h>
 #include <util/time.h>
 #include <validation.h>
-#include <governance/governance.h>
 
 #include <array>
 #include <stdint.h>

src/test/dynamic_activation_thresholds_tests.cpp

@@ -7,12 +7,6 @@
 #include <chainparams.h>
 #include <consensus/validation.h>
 #include <deploymentstatus.h>
-#include <evo/evodb.h>
-#include <governance/governance.h>
-#include <llmq/blockprocessor.h>
-#include <llmq/chainlocks.h>
-#include <llmq/context.h>
-#include <llmq/instantsend.h>
 #include <miner.h>
 #include <script/interpreter.h>
 #include <spork.h>

src/test/util/mining.cpp

@@ -7,12 +7,7 @@
 #include <chainparams.h>
 #include <consensus/merkle.h>
 #include <evo/evodb.h>
-#include <governance/governance.h>
 #include <key_io.h>
-#include <llmq/blockprocessor.h>
-#include <llmq/chainlocks.h>
-#include <llmq/context.h>
-#include <llmq/instantsend.h>
 #include <miner.h>
 #include <node/context.h>
 #include <pow.h>

src/test/util/setup_common.cpp

@@ -18,10 +18,8 @@
 #include <init.h>
 #include <interfaces/chain.h>
 #include <netfulfilledman.h>
-#include <llmq/blockprocessor.h>
 #include <llmq/chainlocks.h>
 #include <llmq/context.h>
-#include <llmq/dkgsessionmgr.h>
 #include <llmq/instantsend.h>
 #include <llmq/quorums.h>
 #include <llmq/signing.h>
@@ -58,11 +56,9 @@
 
 #include <bls/bls.h>
 #ifdef ENABLE_WALLET
-#include <coinjoin/client.h>
+#include <interfaces/coinjoin.h>
 #endif // ENABLE_WALLET
-#include <coinjoin/coinjoin.h>
 #include <coinjoin/context.h>
-#include <coinjoin/server.h>
 #include <evo/cbtx.h>
 #include <evo/chainhelper.h>
 #include <evo/creditpool.h>

src/test/validation_block_tests.cpp

@@ -8,17 +8,10 @@
 #include <consensus/consensus.h>
 #include <consensus/merkle.h>
 #include <consensus/validation.h>
-#include <evo/evodb.h>
-#include <governance/governance.h>
-#include <llmq/blockprocessor.h>
-#include <llmq/chainlocks.h>
-#include <llmq/context.h>
-#include <llmq/instantsend.h>
 #include <miner.h>
 #include <pow.h>
 #include <random.h>
 #include <script/standard.h>
-#include <spork.h>
 #include <test/util/script.h>
 #include <test/util/setup_common.h>
 #include <util/time.h>

src/test/validation_chainstate_tests.cpp

@@ -5,7 +5,6 @@
 #include <consensus/validation.h>
 #include <evo/evodb.h>
 #include <index/txindex.h>
-#include <llmq/blockprocessor.h>
 #include <llmq/chainlocks.h>
 #include <llmq/instantsend.h>
 #include <random.h>

src/test/validation_flush_tests.cpp

@@ -3,7 +3,6 @@
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 //
 #include <evo/evodb.h>
-#include <llmq/blockprocessor.h>
 #include <llmq/chainlocks.h>
 #include <llmq/instantsend.h>
 #include <sync.h>