Merge #18899: travis: Remove valgrind

fa082d0a57afedca9122fac4aecd6a3070f06b04 travis: Remove valgrind (MarcoFalke)

Pull request description:

  When the valgrind run was added, it took 2 hours. Travis kindly raised the timeout limit to the maximum possible of 3 hours.

  Today, a full build of Bitcoin Core with all tests takes more than three hours. Thus, it is impossible to run all tests on travis.

  Moreover, the feedback loop for developers that create a pull request takes at least 2 hours, but in some cases (when the travis queue is full) until the next day. This is unacceptable.

  Fix both issues by removing the build from travis.

  Please note that the `ci/test/` configurations are *not* removed. They will stay in the repo and can be executed anywhere (just not on travis).

ACKs for top commit:
  jamesob:
    ACK fa082d0a57
  jnewbery:
    utACK fa082d0a57afedca9122fac4aecd6a3070f06b04

Tree-SHA512: 9acaa0e2d3926014fadb7dd2e86c4e01df382e9399f6ae99f989fa609da66a77bdd1b75d6ff42d2686f38f730b8564e6dc722aa597a473290c9d30c2abe7ef0f

.gitlab-ci.yml

@@ -279,14 +279,14 @@ linux64_nowallet-build:
   variables:
     BUILD_TARGET: linux64_nowallet
 
-linux64_valgrind-build:
+#linux64_valgrind-build:
-  extends:
+#  extends:
-    - .build-template
+#    - .build-template
-    - .skip-in-fast-mode-template
+#    - .skip-in-fast-mode-template
-  needs:
+#  needs:
-    - x86_64-pc-linux-gnu-debug
+#    - x86_64-pc-linux-gnu-debug
-  variables:
+#  variables:
-    BUILD_TARGET: linux64_valgrind
+#    BUILD_TARGET: linux64_valgrind
 
 mac-build:
   extends:
@@ -333,11 +333,11 @@ linux64_ubsan-test:
   variables:
     BUILD_TARGET: linux64_ubsan
 
-linux64_valgrind-test:
+#linux64_valgrind-test:
-  extends:
+#  extends:
-    - .test-template
+#    - .test-template
-    - .skip-in-fast-mode-template
+#    - .skip-in-fast-mode-template
-  needs:
+#  needs:
-    - linux64_valgrind-build
+#    - linux64_valgrind-build
-  variables:
+#  variables:
-    BUILD_TARGET: linux64_valgrind
+#    BUILD_TARGET: linux64_valgrind

.travis.yml

@@ -240,22 +240,13 @@ after_success:
       env: >-
         FILE_ENV="./ci/test/00_setup_env_native_asan.sh"
 
-    - stage: test
-      name: 'x86_64 Linux  [GOAL: install]  [focal]  [no depends, only system libs, valgrind]'
-      env: >-
-        FILE_ENV="./ci/test/00_setup_env_native_valgrind.sh"
-
     - stage: test
       name: 'x86_64 Linux  [GOAL: install]  [focal]  [no wallet]'
       env: >-
         FILE_ENV="./ci/test/00_setup_env_native_fuzz.sh"
 
     - stage: test
-      name: 'x86_64 Linux  [GOAL: install]  [focal]  [no depends, only system libs, fuzzers under valgrind]'
+      name: 'x86_64 Linux  [GOAL: install]  [focal]  [no wallet]'
-      env: >-
-        FILE_ENV="./ci/test/00_setup_env_native_fuzz_with_valgrind.sh"
-
-    - stage: test
       env: >-
         FILE_ENV="./ci/test/00_setup_env_native_nowallet.sh"