sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 20:12:57 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #12710: Append scripts to new test_list array to fix bad assignment

Browse Source 
b0fec8d623 Append scripts to new test_list array to fix bad assignment (Jeff Rade)

Pull request description:

  Fixes review by @MarcoFalke in PR [#12437](https://github.com/bitcoin/bitcoin/pull/12437)

  Assignment of `test_list` would point to the same array object as `BASE_SCRIPT` or `ALL_SCRIPTS` which we do not want.

Tree-SHA512: 57d6c1f4563aaffbac68e96782283799b10be687292152d70ffbbc22e7b52c11c1af0c483acb01c69fbaa99bdae01431b65a5d1d0a913d549f58dfd95d0d28d9
This commit is contained in:
MarcoFalke 2018-03-17 19:28:02 -04:00 committed by pasta
parent 19e2de1b22
commit 3d252a72b2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/functional/test_runner.py
View File

@ -252,11 +252,11 @@ def main():
sys.exit(0) sys.exit(0)
# Build list of tests # Build list of tests
test_list = []
if tests: if tests:
# Individual tests have been specified. Run specified tests that exist # Individual tests have been specified. Run specified tests that exist
# in the ALL_SCRIPTS list. Accept the name with or without .py extension. # in the ALL_SCRIPTS list. Accept the name with or without .py extension.
tests = [re.sub("\.py$", "", test) + ".py" for test in tests] tests = [re.sub("\.py$", "", test) + ".py" for test in tests]
test_list = []
for test in tests: for test in tests:
if test in ALL_SCRIPTS: if test in ALL_SCRIPTS:
test_list.append(test) test_list.append(test)
@ -264,10 +264,10 @@ def main():
print("{}WARNING!{} Test '{}' not found in full test list.".format(BOLD[1], BOLD[0], test)) print("{}WARNING!{} Test '{}' not found in full test list.".format(BOLD[1], BOLD[0], test))
elif args.extended: elif args.extended:
# Include extended tests # Include extended tests
test_list = ALL_SCRIPTS test_list += ALL_SCRIPTS
else: else:
# Run base tests only # Run base tests only
test_list = BASE_SCRIPTS test_list += BASE_SCRIPTS
# Remove the test cases that the user has explicitly asked to exclude. # Remove the test cases that the user has explicitly asked to exclude.
if args.exclude: if args.exclude: