From ccef3b48363d8bff4b919d9119355182e3902ef3 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Mon, 16 Nov 2020 00:19:03 +0300 Subject: [PATCH 1/5] qt: Fix wallet encryption dialog (#3816) Do not rely on `checked` status of `encryptWalletAction` --- src/qt/bitcoingui.cpp | 2 +- src/qt/walletframe.cpp | 4 ++-- src/qt/walletframe.h | 2 +- src/qt/walletview.cpp | 4 ++-- src/qt/walletview.h | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp index 2e0dced4b9..e128f3b258 100644 --- a/src/qt/bitcoingui.cpp +++ b/src/qt/bitcoingui.cpp @@ -575,7 +575,7 @@ void BitcoinGUI::createActions() #ifdef ENABLE_WALLET if(walletFrame) { - connect(encryptWalletAction, SIGNAL(triggered(bool)), walletFrame, SLOT(encryptWallet(bool))); + connect(encryptWalletAction, SIGNAL(triggered()), walletFrame, SLOT(encryptWallet())); connect(backupWalletAction, SIGNAL(triggered()), walletFrame, SLOT(backupWallet())); connect(changePassphraseAction, SIGNAL(triggered()), walletFrame, SLOT(changePassphrase())); connect(unlockWalletAction, SIGNAL(triggered()), walletFrame, SLOT(unlockWallet())); diff --git a/src/qt/walletframe.cpp b/src/qt/walletframe.cpp index 7c55792059..ca1ae0d0a0 100644 --- a/src/qt/walletframe.cpp +++ b/src/qt/walletframe.cpp @@ -166,11 +166,11 @@ void WalletFrame::gotoVerifyMessageTab(QString addr) walletView->gotoVerifyMessageTab(addr); } -void WalletFrame::encryptWallet(bool status) +void WalletFrame::encryptWallet() { WalletView *walletView = currentWalletView(); if (walletView) - walletView->encryptWallet(status); + walletView->encryptWallet(); } void WalletFrame::backupWallet() diff --git a/src/qt/walletframe.h b/src/qt/walletframe.h index 02340d1027..9f1961d9b9 100644 --- a/src/qt/walletframe.h +++ b/src/qt/walletframe.h @@ -79,7 +79,7 @@ public Q_SLOTS: void gotoVerifyMessageTab(QString addr = ""); /** Encrypt the wallet */ - void encryptWallet(bool status); + void encryptWallet(); /** Backup the wallet */ void backupWallet(); /** Change encrypted wallet passphrase */ diff --git a/src/qt/walletview.cpp b/src/qt/walletview.cpp index 2bb1a177ad..4abf863e14 100644 --- a/src/qt/walletview.cpp +++ b/src/qt/walletview.cpp @@ -299,11 +299,11 @@ void WalletView::updateEncryptionStatus() Q_EMIT encryptionStatusChanged(walletModel->getEncryptionStatus()); } -void WalletView::encryptWallet(bool status) +void WalletView::encryptWallet() { if(!walletModel) return; - AskPassphraseDialog dlg(status ? AskPassphraseDialog::Encrypt : AskPassphraseDialog::Decrypt, this); + AskPassphraseDialog dlg(AskPassphraseDialog::Encrypt, this); dlg.setModel(walletModel); dlg.exec(); diff --git a/src/qt/walletview.h b/src/qt/walletview.h index c6b5ab5c31..6a041ac7f9 100644 --- a/src/qt/walletview.h +++ b/src/qt/walletview.h @@ -99,7 +99,7 @@ public Q_SLOTS: */ void processNewTransaction(const QModelIndex& parent, int start, int /*end*/); /** Encrypt the wallet */ - void encryptWallet(bool status); + void encryptWallet(); /** Backup the wallet */ void backupWallet(); /** Change encrypted wallet passphrase */ From 11f47917bbd07784f2e405b6f4f224760d7f1222 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Sun, 15 Nov 2020 15:06:46 +0300 Subject: [PATCH 2/5] bump version in configure.ac --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 0ac87f21f5..b22ff50fb2 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.60]) define(_CLIENT_VERSION_MAJOR, 0) define(_CLIENT_VERSION_MINOR, 16) define(_CLIENT_VERSION_REVISION, 1) -define(_CLIENT_VERSION_BUILD, 0) +define(_CLIENT_VERSION_BUILD, 1) define(_CLIENT_VERSION_IS_RELEASE, true) define(_COPYRIGHT_YEAR, 2020) define(_COPYRIGHT_HOLDERS,[The %s developers]) From 7982a7fc256b2d7461bebe39be239902f50e6ed2 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Sun, 15 Nov 2020 15:09:04 +0300 Subject: [PATCH 3/5] bump version in man pages --- doc/man/dash-cli.1 | 6 +++--- doc/man/dash-qt.1 | 6 +++--- doc/man/dash-tx.1 | 6 +++--- doc/man/dashd.1 | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/man/dash-cli.1 b/doc/man/dash-cli.1 index b994710979..fa2b208384 100644 --- a/doc/man/dash-cli.1 +++ b/doc/man/dash-cli.1 @@ -1,9 +1,9 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.47.16. -.TH DASH-CLI "1" "November 2020" "dash-cli v0.16.1.0" "User Commands" +.TH DASH-CLI "1" "November 2020" "dash-cli v0.16.1.1" "User Commands" .SH NAME -dash-cli \- manual page for dash-cli v0.16.1.0 +dash-cli \- manual page for dash-cli v0.16.1.1 .SH DESCRIPTION -Dash Core RPC client version v0.16.1.0 +Dash Core RPC client version v0.16.1.1 .SS "Usage:" .TP dash\-cli [options] [params] diff --git a/doc/man/dash-qt.1 b/doc/man/dash-qt.1 index 0fa4008755..4d7cbb9ffd 100644 --- a/doc/man/dash-qt.1 +++ b/doc/man/dash-qt.1 @@ -1,9 +1,9 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.47.16. -.TH DASH-QT "1" "November 2020" "dash-qt v0.16.1.0" "User Commands" +.TH DASH-QT "1" "November 2020" "dash-qt v0.16.1.1" "User Commands" .SH NAME -dash-qt \- manual page for dash-qt v0.16.1.0 +dash-qt \- manual page for dash-qt v0.16.1.1 .SH DESCRIPTION -Dash Core version v0.16.1.0 (64\-bit) +Dash Core version v0.16.1.1 (64\-bit) Usage: .IP dash\-qt [command\-line options] diff --git a/doc/man/dash-tx.1 b/doc/man/dash-tx.1 index a8bf40d7d6..d891f421b9 100644 --- a/doc/man/dash-tx.1 +++ b/doc/man/dash-tx.1 @@ -1,9 +1,9 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.47.16. -.TH DASH-TX "1" "November 2020" "dash-tx v0.16.1.0" "User Commands" +.TH DASH-TX "1" "November 2020" "dash-tx v0.16.1.1" "User Commands" .SH NAME -dash-tx \- manual page for dash-tx v0.16.1.0 +dash-tx \- manual page for dash-tx v0.16.1.1 .SH DESCRIPTION -Dash Core dash\-tx utility version v0.16.1.0 +Dash Core dash\-tx utility version v0.16.1.1 .SS "Usage:" .TP dash\-tx [options] [commands] diff --git a/doc/man/dashd.1 b/doc/man/dashd.1 index f103fc241c..019eceec5c 100644 --- a/doc/man/dashd.1 +++ b/doc/man/dashd.1 @@ -1,9 +1,9 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.47.16. -.TH DASHD "1" "November 2020" "dashd v0.16.1.0" "User Commands" +.TH DASHD "1" "November 2020" "dashd v0.16.1.1" "User Commands" .SH NAME -dashd \- manual page for dashd v0.16.1.0 +dashd \- manual page for dashd v0.16.1.1 .SH DESCRIPTION -Dash Core Daemon version v0.16.1.0 +Dash Core Daemon version v0.16.1.1 .SS "Usage:" .TP dashd [options] From 054a2b3cfbfaec45c7668444dccdb19080efef3a Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Sun, 15 Nov 2020 15:10:52 +0300 Subject: [PATCH 4/5] Archive 0.16.1.0 release notes --- .../dash/release-notes-0.16.1.0.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename doc/{release-notes.md => release-notes/dash/release-notes-0.16.1.0.md} (100%) diff --git a/doc/release-notes.md b/doc/release-notes/dash/release-notes-0.16.1.0.md similarity index 100% rename from doc/release-notes.md rename to doc/release-notes/dash/release-notes-0.16.1.0.md From 1734872895fb989904b219b133d66aa460d157a9 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Mon, 16 Nov 2020 00:27:33 +0300 Subject: [PATCH 5/5] Add v0.16.1.1 release notes --- doc/release-notes.md | 121 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 121 insertions(+) create mode 100644 doc/release-notes.md diff --git a/doc/release-notes.md b/doc/release-notes.md new file mode 100644 index 0000000000..d897d64ff6 --- /dev/null +++ b/doc/release-notes.md @@ -0,0 +1,121 @@ +Dash Core version 0.16.1.1 +========================== + +Release is now available from: + + + +This is a new hotfix release. + +Please report bugs using the issue tracker at github: + + + + +Upgrading and downgrading +========================= + +How to Upgrade +-------------- + +If you are running an older version, shut it down. Wait until it has completely +shut down (which might take a few minutes for older versions), then run the +installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or +dashd/dash-qt (on Linux). If you upgrade after DIP0003 activation and you were +using version < 0.13 you will have to reindex (start with -reindex-chainstate +or -reindex) to make sure your wallet has all the new data synced. Upgrading +from version 0.13 should not require any additional actions. + +When upgrading from a version prior to 0.14.0.3, the +first startup of Dash Core will run a migration process which can take a few +minutes to finish. After the migration, a downgrade to an older version is only +possible with a reindex (or reindex-chainstate). + +Downgrade warning +----------------- + +### Downgrade to a version < 0.14.0.3 + +Downgrading to a version older than 0.14.0.3 is no longer supported due to +changes in the "evodb" database format. If you need to use an older version, +you must either reindex or re-sync the whole chain. + +### Downgrade of masternodes to < 0.16 + +Starting with this release, masternodes will verify the protocol version of other +masternodes. This will result in PoSe punishment/banning for outdated masternodes, +so downgrading is not recommended. + +Notable changes +=============== + +There was an unexpected behaviour of the "Encrypt wallet" menu item for unencrypted wallets +which was showing users the "Decrypt wallet" dialog instead. This was a GUI only issue, +internal encryption logic and RPC behaviour were not affected. + +0.16.1.1 Change log +=================== + +See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.16.1.0...dashpay:v0.16.1.1). + +- [`ccef3b4836`](https://github.com/dashpay/dash/commit/ccef3b48363d8bff4b919d9119355182e3902ef3) qt: Fix wallet encryption dialog (#3816) + +Credits +======= + +Thanks to everyone who directly contributed to this release: + +- UdjinM6 + +As well as everyone that submitted issues and reviewed pull requests. + +Older releases +============== + +Dash was previously known as Darkcoin. + +Darkcoin tree 0.8.x was a fork of Litecoin tree 0.8, original name was XCoin +which was first released on Jan/18/2014. + +Darkcoin tree 0.9.x was the open source implementation of masternodes based on +the 0.8.x tree and was first released on Mar/13/2014. + +Darkcoin tree 0.10.x used to be the closed source implementation of Darksend +which was released open source on Sep/25/2014. + +Dash Core tree 0.11.x was a fork of Bitcoin Core tree 0.9, +Darkcoin was rebranded to Dash. + +Dash Core tree 0.12.0.x was a fork of Bitcoin Core tree 0.10. + +Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12. + +These release are considered obsolete. Old release notes can be found here: + +- [v0.16.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.0.md) released November/14/2020 +- [v0.16.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.0.1.md) released September/30/2020 +- [v0.15.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.15.0.0.md) released Febrary/18/2020 +- [v0.14.0.5](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.5.md) released December/08/2019 +- [v0.14.0.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.4.md) released November/22/2019 +- [v0.14.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.3.md) released August/15/2019 +- [v0.14.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.2.md) released July/4/2019 +- [v0.14.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.1.md) released May/31/2019 +- [v0.14.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.md) released May/22/2019 +- [v0.13.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.3.md) released Apr/04/2019 +- [v0.13.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.2.md) released Mar/15/2019 +- [v0.13.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.1.md) released Feb/9/2019 +- [v0.13.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.0.md) released Jan/14/2019 +- [v0.12.3.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.4.md) released Dec/14/2018 +- [v0.12.3.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.3.md) released Sep/19/2018 +- [v0.12.3.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.2.md) released Jul/09/2018 +- [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018 +- [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018 +- [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017 +- [v0.12.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.md) released Nov/08/2017 +- [v0.12.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.1.md) released Feb/06/2017 +- [v0.12.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.0.md) released Aug/15/2015 +- [v0.11.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.2.md) released Mar/04/2015 +- [v0.11.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.1.md) released Feb/10/2015 +- [v0.11.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.0.md) released Jan/15/2015 +- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014 +- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014