mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 03:52:49 +01:00
merge bitcoin#21677: Avoid use of low file descriptor ids (which may be in use) in FuzzedSock
This commit is contained in:
parent
1b82b4f161
commit
4972126d95
@ -536,15 +536,15 @@ class FuzzedSock : public Sock
|
||||
public:
|
||||
explicit FuzzedSock(FuzzedDataProvider& fuzzed_data_provider) : m_fuzzed_data_provider{fuzzed_data_provider}
|
||||
{
|
||||
m_socket = fuzzed_data_provider.ConsumeIntegral<SOCKET>();
|
||||
m_socket = fuzzed_data_provider.ConsumeIntegralInRange<SOCKET>(INVALID_SOCKET - 1, INVALID_SOCKET);
|
||||
}
|
||||
|
||||
~FuzzedSock() override
|
||||
{
|
||||
// Sock::~Sock() will be called after FuzzedSock::~FuzzedSock() and it will call
|
||||
// Sock::Reset() (not FuzzedSock::Reset()!) which will call CloseSocket(m_socket).
|
||||
// Avoid closing an arbitrary file descriptor (m_socket is just a random number which
|
||||
// may concide with a real opened file descriptor).
|
||||
// Avoid closing an arbitrary file descriptor (m_socket is just a random very high number which
|
||||
// theoretically may concide with a real opened file descriptor).
|
||||
Reset();
|
||||
}
|
||||
|
||||
|
@ -70,8 +70,7 @@ public:
|
||||
explicit StaticContentsSock(const std::string& contents) : m_contents{contents}, m_consumed{0}
|
||||
{
|
||||
// Just a dummy number that is not INVALID_SOCKET.
|
||||
static_assert(INVALID_SOCKET != 1000);
|
||||
m_socket = 1000;
|
||||
m_socket = INVALID_SOCKET - 1;
|
||||
}
|
||||
|
||||
~StaticContentsSock() override { Reset(); }
|
||||
|
Loading…
Reference in New Issue
Block a user