sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 20:12:57 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

test: don't attempt to (dis)connect nodes to/from themselves

Browse Source
This commit is contained in:
Kittywhiskers Van Gogh 2024-09-19 11:21:16 +00:00
parent c200175ebf
commit 4a0fc8b69e
No known key found for this signature in database
GPG Key ID: 30CD0C065E5C4AAD
6 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/functional/feature_dip3_v19.py
View File

@ -54,7 +54,6 @@ class DIP3V19Test(DashTestFramework):
null_hash = format(0, "064x") null_hash = format(0, "064x")
for i in range(len(self.nodes)): for i in range(len(self.nodes)):
if i != 0:
self.connect_nodes(i, 0) self.connect_nodes(i, 0)
self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0) self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0)

2
test/functional/feature_llmq_chainlocks.py
View File

@ -23,12 +23,10 @@ class LLMQChainLocksTest(DashTestFramework):
self.set_dash_test_params(5, 4, fast_dip3_enforcement=True) self.set_dash_test_params(5, 4, fast_dip3_enforcement=True)
def run_test(self): def run_test(self):
# Connect all nodes to node1 so that we always have the whole network connected # Connect all nodes to node1 so that we always have the whole network connected
# Otherwise only masternode connections will be established between nodes, which won't propagate TXs/blocks # Otherwise only masternode connections will be established between nodes, which won't propagate TXs/blocks
# Usually node0 is the one that does this, but in this test we isolate it multiple times # Usually node0 is the one that does this, but in this test we isolate it multiple times
for i in range(len(self.nodes)): for i in range(len(self.nodes)):
if i != 1:
self.connect_nodes(i, 1) self.connect_nodes(i, 1)
self.test_coinbase_best_cl(self.nodes[0], expected_cl_in_cb=False) self.test_coinbase_best_cl(self.nodes[0], expected_cl_in_cb=False)

1
test/functional/feature_llmq_evo.py
View File

@ -58,7 +58,6 @@ class LLMQEvoNodesTest(DashTestFramework):
null_hash = format(0, "064x") null_hash = format(0, "064x")
for i in range(len(self.nodes)): for i in range(len(self.nodes)):
if i != 0:
self.connect_nodes(i, 0) self.connect_nodes(i, 0)
self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0) self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0)

1
test/functional/feature_llmq_rotation.py
View File

@ -65,7 +65,6 @@ class LLMQQuorumRotationTest(DashTestFramework):
# Usually node0 is the one that does this, but in this test we isolate it multiple times # Usually node0 is the one that does this, but in this test we isolate it multiple times
for i in range(len(self.nodes)): for i in range(len(self.nodes)):
if i != 1:
self.connect_nodes(i, 0) self.connect_nodes(i, 0)
self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0) self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 0)

8
test/functional/test_framework/test_framework.py
View File

@ -692,6 +692,10 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass):
self.nodes[i].process.wait(timeout) self.nodes[i].process.wait(timeout)
def connect_nodes(self, a, b): def connect_nodes(self, a, b):
# A node cannot connect to itself, bail out early
if (a == b):
return
def connect_nodes_helper(from_connection, node_num): def connect_nodes_helper(from_connection, node_num):
ip_port = "127.0.0.1:" + str(p2p_port(node_num)) ip_port = "127.0.0.1:" + str(p2p_port(node_num))
from_connection.addnode(ip_port, "onetry") from_connection.addnode(ip_port, "onetry")
@ -706,6 +710,10 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass):
connect_nodes_helper(self.nodes[a], b) connect_nodes_helper(self.nodes[a], b)
def disconnect_nodes(self, a, b): def disconnect_nodes(self, a, b):
# A node cannot disconnect from itself, bail out early
if (a == b):
return
def disconnect_nodes_helper(from_connection, node_num): def disconnect_nodes_helper(from_connection, node_num):
def get_peer_ids(): def get_peer_ids():
result = [] result = []