merge bitcoin#23439: Open streams_test_tmp file in temporary folder

This commit is contained in:
Kittywhiskers Van Gogh 2021-11-04 18:46:57 +01:00
parent e3e225f59d
commit 4a46391791
No known key found for this signature in database
GPG Key ID: 30CD0C065E5C4AAD

View File

@ -197,7 +197,9 @@ BOOST_AUTO_TEST_CASE(streams_serializedata_xor)
BOOST_AUTO_TEST_CASE(streams_buffered_file) BOOST_AUTO_TEST_CASE(streams_buffered_file)
{ {
FILE* file = fsbridge::fopen("streams_test_tmp", "w+b"); fs::path streams_test_filename = m_args.GetDataDirBase() / "streams_test_tmp";
FILE* file = fsbridge::fopen(streams_test_filename, "w+b");
// The value at each offset is the offset. // The value at each offset is the offset.
for (uint8_t j = 0; j < 40; ++j) { for (uint8_t j = 0; j < 40; ++j) {
fwrite(&j, 1, 1, file); fwrite(&j, 1, 1, file);
@ -325,7 +327,7 @@ BOOST_AUTO_TEST_CASE(streams_buffered_file)
// We can explicitly close the file, or the destructor will do it. // We can explicitly close the file, or the destructor will do it.
bf.fclose(); bf.fclose();
fs::remove("streams_test_tmp"); fs::remove(streams_test_filename);
} }
BOOST_AUTO_TEST_CASE(streams_buffered_file_skip) BOOST_AUTO_TEST_CASE(streams_buffered_file_skip)
@ -382,8 +384,9 @@ BOOST_AUTO_TEST_CASE(streams_buffered_file_rand)
// Make this test deterministic. // Make this test deterministic.
SeedInsecureRand(SeedRand::ZEROS); SeedInsecureRand(SeedRand::ZEROS);
fs::path streams_test_filename = m_args.GetDataDirBase() / "streams_test_tmp";
for (int rep = 0; rep < 50; ++rep) { for (int rep = 0; rep < 50; ++rep) {
FILE* file = fsbridge::fopen("streams_test_tmp", "w+b"); FILE* file = fsbridge::fopen(streams_test_filename, "w+b");
size_t fileSize = InsecureRandRange(256); size_t fileSize = InsecureRandRange(256);
for (uint8_t i = 0; i < fileSize; ++i) { for (uint8_t i = 0; i < fileSize; ++i) {
fwrite(&i, 1, 1, file); fwrite(&i, 1, 1, file);
@ -494,7 +497,7 @@ BOOST_AUTO_TEST_CASE(streams_buffered_file_rand)
maxPos = currentPos; maxPos = currentPos;
} }
} }
fs::remove("streams_test_tmp"); fs::remove(streams_test_filename);
} }
BOOST_AUTO_TEST_CASE(streams_hashed) BOOST_AUTO_TEST_CASE(streams_hashed)