sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-24 19:42:46 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: add check that DIP0003 activated before retrieving CbTx for CreditPool

Browse Source
This commit is contained in:
Konstantin Akimov 2024-11-21 16:05:27 +07:00
parent 26e9813672
commit 4dafec870c
No known key found for this signature in database
GPG Key ID: 2176C4A5D01EA524
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/evo/creditpool.cpp
View File

@ -114,17 +114,20 @@ void CCreditPoolManager::AddToCache(const uint256& block_hash, int height, const
static std::optional<CBlock> GetBlockForCreditPool(const CBlockIndex* const block_index, const Consensus::Params& consensusParams) static std::optional<CBlock> GetBlockForCreditPool(const CBlockIndex* const block_index, const Consensus::Params& consensusParams)
{ {
// There's no CbTx before DIP0003 activation
if (!DeploymentActiveAt(*block_index, Params().GetConsensus(), Consensus::DEPLOYMENT_DIP0003)) {
return std::nullopt;
}
CBlock block; CBlock block;
if (!ReadBlockFromDisk(block, block_index, consensusParams)) { if (!ReadBlockFromDisk(block, block_index, consensusParams)) {
throw std::runtime_error("failed-getcbforblock-read"); throw std::runtime_error("failed-getcbforblock-read");
} }
assert(!block.vtx.empty()); if (block.vtx.empty() || block.vtx[0]->vExtraPayload.empty() || !block.vtx[0]->IsSpecialTxVersion()) {
LogPrintf("%s: ERROR: empty CbTx for CreditPool at height=%d\n", __func__, block_index->nHeight);
// Should not fail if V20 (DIP0027) is active but it happens for RegChain (unit tests) return std::nullopt;
if (!block.vtx[0]->IsSpecialTxVersion()) return std::nullopt; }
assert(!block.vtx[0]->vExtraPayload.empty());
return block; return block;
} }