sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-26 20:42:59 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #21274: assumptions: Assume C++17

Browse Source 
5e531e6beb5381c0be5efaa24b7e423e593568e4 assumptions: check C++17 assumption with MSVC (fanquake)
c7b46489f8c4d880382248fb47266d81948bbce0 assumptions: assume a C++17 compiler (fanquake)

Pull request description:

  This has been the case since #20413.

  This should also enable the check for MSVC. From my reading of https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-160 and https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/ if we set the `/Zc:__cplusplus` switch in additional options, MSVC will report the correct value for `__cplusplus`. However I have not tested this.

ACKs for top commit:
  laanwj:
    Code review ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4
  hebasto:
    ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4, checked the MS docs, and AppVeyor build is green.
  practicalswift:
    ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4

Tree-SHA512: a4fb525cf5c33abc944c614edb0313a39c8a39a1637a03c09342c15ba0925f4eb037062e65e51b42ade667506b7e554c7159acf86e6b8c35d0a87dd79a6f239b
This commit is contained in:
MarcoFalke 2021-02-23 14:03:24 +01:00 committed by PastaPastaPasta
parent 33d5b89d24
commit 52d7dbe329
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/compat/assumptions.h
View File

@ -17,16 +17,12 @@
# error "Dash Core cannot be compiled without assertions." # error "Dash Core cannot be compiled without assertions."
#endif #endif
// Assumption: We assume a C++11 (ISO/IEC 14882:2011) compiler (minimum requirement). // Assumption: We assume a C++17 (ISO/IEC 14882:2017) compiler (minimum requirement).
// Example(s): We assume the presence of C++11 features everywhere :-) // Example(s): We assume the presence of C++17 features everywhere :-)
// Note: MSVC does not report the expected __cplusplus value due to legacy // ISO Standard C++17 [cpp.predefined]p1:
// reasons. // "The name __cplusplus is defined to the value 201703L when compiling a C++
#if !defined(_MSC_VER)
// ISO Standard C++11 [cpp.predefined]p1:
// "The name __cplusplus is defined to the value 201103L when compiling a C++
// translation unit." // translation unit."
static_assert(__cplusplus >= 201103L, "C++11 standard assumed"); static_assert(__cplusplus >= 201703L, "C++17 standard assumed");
#endif
// Assumption: We assume the floating-point types to fulfill the requirements of // Assumption: We assume the floating-point types to fulfill the requirements of
// IEC 559 (IEEE 754) standard. // IEC 559 (IEEE 754) standard.