From 551109105ac73d13feb45ecea7ae18cb0b21eac7 Mon Sep 17 00:00:00 2001
From: fanquake <fanquake@gmail.com>
Date: Fri, 7 Jul 2023 09:40:22 +0100
Subject: [PATCH] Merge bitcoin/bitcoin#28036: test: Restore unlimited timeout
 in IndexWaitSynced

fabed7eb796637c02e3677ebbe183d90b258ba69 test: Restore unlimited timeout in IndexWaitSynced (MarcoFalke)

Pull request description:

  The timeout was unlimited before, so just restore that value for now: https://github.com/bitcoin/bitcoin/pull/27988#issuecomment-1619218007 .

  (Strictly speaking, this is a behavior change for the blockfilterindex and txindex tests, because it only restores the coinstatsindex behavior.)

ACKs for top commit:
  ajtowns:
    utACK fabed7eb796637c02e3677ebbe183d90b258ba69
  mzumsande:
    ACK fabed7eb796637c02e3677ebbe183d90b258ba69
  furszy:
    ACK fabed7eb

Tree-SHA512: 66a878be58bbe53ad8e0c23f05569dd42df688be747551fbd202ada22d20a8285714e58fa2a71664deadb070ddf86cfad88c01042ff95ed26f6b40e4a10cec0a
---
 src/test/util/index.cpp | 5 +----
 src/test/util/index.h   | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/test/util/index.cpp b/src/test/util/index.cpp
index 2bda7b1773..89bc35b731 100644
--- a/src/test/util/index.cpp
+++ b/src/test/util/index.cpp
@@ -5,14 +5,11 @@
 #include <test/util/index.h>
 
 #include <index/base.h>
-#include <util/check.h>
 #include <util/time.h>
 
-void IndexWaitSynced(BaseIndex& index)
+void IndexWaitSynced(const BaseIndex& index)
 {
-    const auto timeout{SteadyClock::now() + 120s};
     while (!index.BlockUntilSyncedToCurrentChain()) {
-        Assert(timeout > SteadyClock::now());
         UninterruptibleSleep(100ms);
     }
 }
diff --git a/src/test/util/index.h b/src/test/util/index.h
index 02030fd562..95309f6273 100644
--- a/src/test/util/index.h
+++ b/src/test/util/index.h
@@ -8,6 +8,6 @@
 class BaseIndex;
 
 /** Block until the index is synced to the current chain */
-void IndexWaitSynced(BaseIndex& index);
+void IndexWaitSynced(const BaseIndex& index);
 
 #endif // BITCOIN_TEST_UTIL_INDEX_H