sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #8915: Add copyright/patent issues to possible NACK reasons

Browse Source 
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
This commit is contained in:
MarcoFalke 2016-10-14 09:52:29 +02:00 committed by Alexander Block
parent dcc63e6e9f
commit 552fafdae6
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -178,7 +178,9 @@ language is used within pull-request comments:
- ACK means "I have tested the code and I agree it should be merged"; - ACK means "I have tested the code and I agree it should be merged";
- NACK means "I disagree this should be merged", and must be accompanied by - NACK means "I disagree this should be merged", and must be accompanied by
sound technical justification. NACKs without accompanying reasoning may be disregarded; sound technical justification (or in certain cases of copyright/patent/licensing
issues, legal justification). NACKs without accompanying reasoning may be
disregarded;
- utACK means "I have not tested the code, but I have reviewed it and it looks - utACK means "I have not tested the code, but I have reviewed it and it looks
OK, I agree it can be merged"; OK, I agree it can be merged";
- Concept ACK means "I agree in the general principle of this pull request"; - Concept ACK means "I agree in the general principle of this pull request";