mirror of
https://github.com/dashpay/dash.git
synced 2024-12-24 19:42:46 +01:00
Merge #21345: test: bring p2p_leak.py up to date
a061a299708d39ad63f85085ae07c457308823cf test: bring p2p_leak.py up to date. (Martin Zumsande) Pull request description: After the introduction of wtxidrelay and sendaddrv2 messages during version handshake, extend p2p_leak.py test to reflect this. Also, some minor fixes and doc improvements. I also added a test that peers not completing the version handshake will be disconnected for timeout, as suggested by MarcoFalke in https://github.com/bitcoin/bitcoin/pull/19723#issuecomment-699540294. ACKs for top commit: brunoerg: Tested ACK a061a299708d39ad63f85085ae07c457308823cf theStack: Tested ACK a061a299708d39ad63f85085ae07c457308823cf Tree-SHA512: 26c601491fa8710fc972d1b8f15da6b387a95b42bbfb629ec4c668769ad3824b6dd6a33d97363bca2171e403d8d1ce08abf3e5c9cab34f98d53e0109b1c7a0e5
This commit is contained in:
parent
3a18f087bf
commit
58b95338eb
@ -4,8 +4,8 @@
|
||||
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
"""Test message sending before handshake completion.
|
||||
|
||||
A node should never send anything other than VERSION/VERACK until it's
|
||||
received a VERACK.
|
||||
Before receiving a VERACK, a node should not send anything but VERSION/VERACK
|
||||
and feature negotiation messages ( SENDADDRV2).
|
||||
|
||||
This test connects to a node and sends it a few messages, trying to entice it
|
||||
into sending us something it shouldn't.
|
||||
@ -36,10 +36,11 @@ class LazyPeer(P2PInterface):
|
||||
super().__init__()
|
||||
self.unexpected_msg = False
|
||||
self.ever_connected = False
|
||||
self.got_sendaddrv2 = False
|
||||
|
||||
def bad_message(self, message):
|
||||
self.unexpected_msg = True
|
||||
self.log.info("should not have received message: %s" % message.msgtype)
|
||||
print("should not have received message: %s" % message.msgtype)
|
||||
|
||||
def on_open(self):
|
||||
self.ever_connected = True
|
||||
@ -64,6 +65,7 @@ class LazyPeer(P2PInterface):
|
||||
def on_cmpctblock(self, message): self.bad_message(message)
|
||||
def on_getblocktxn(self, message): self.bad_message(message)
|
||||
def on_blocktxn(self, message): self.bad_message(message)
|
||||
def on_sendaddrv2(self, message): self.got_sendaddrv2 = True
|
||||
|
||||
|
||||
# Peer that sends a version but not a verack.
|
||||
@ -96,15 +98,25 @@ class P2PLeakTest(BitcoinTestFramework):
|
||||
self.num_nodes = 1
|
||||
self.disable_mocktime = True
|
||||
|
||||
def create_old_version(self, nversion):
|
||||
old_version_msg = msg_version()
|
||||
old_version_msg.nVersion = nversion
|
||||
old_version_msg.strSubVer = P2P_SUBVERSION
|
||||
old_version_msg.nServices = P2P_SERVICES
|
||||
old_version_msg.relay = P2P_VERSION_RELAY
|
||||
return old_version_msg
|
||||
|
||||
|
||||
def run_test(self):
|
||||
# Another peer that never sends a version, nor any other messages. It shouldn't receive anything from the node.
|
||||
self.log.info('Check that the node doesn\'t send unexpected messages before handshake completion')
|
||||
# Peer that never sends a version, nor any other messages. It shouldn't receive anything from the node.
|
||||
no_version_idle_peer = self.nodes[0].add_p2p_connection(LazyPeer(), send_version=False, wait_for_verack=False)
|
||||
|
||||
# Peer that sends a version but not a verack.
|
||||
no_verack_idle_peer = self.nodes[0].add_p2p_connection(NoVerackIdlePeer(), wait_for_verack=False)
|
||||
|
||||
# Wait until we got the verack in response to the version. Though, don't wait for the node to receive the
|
||||
# verack, since we never sent one
|
||||
# Wait until the peer gets the verack in response to the version. Though, don't wait for the node to receive the
|
||||
# verack, since the peer never sent one
|
||||
no_verack_idle_peer.wait_for_verack()
|
||||
|
||||
no_version_idle_peer.wait_until(lambda: no_version_idle_peer.ever_connected)
|
||||
@ -116,11 +128,16 @@ class P2PLeakTest(BitcoinTestFramework):
|
||||
# Give the node enough time to possibly leak out a message
|
||||
time.sleep(5)
|
||||
|
||||
self.nodes[0].disconnect_p2ps()
|
||||
# Make sure only expected messages came in
|
||||
assert not no_version_idle_peer.unexpected_msg
|
||||
assert not no_version_idle_peer.got_sendaddrv2
|
||||
|
||||
# Make sure no unexpected messages came in
|
||||
assert no_version_idle_peer.unexpected_msg == False
|
||||
assert no_verack_idle_peer.unexpected_msg == False
|
||||
assert not no_verack_idle_peer.unexpected_msg
|
||||
assert no_verack_idle_peer.got_sendaddrv2
|
||||
|
||||
# Expect peers to be disconnected due to timeout
|
||||
assert not no_version_idle_peer.is_connected
|
||||
assert not no_verack_idle_peer.is_connected
|
||||
|
||||
self.log.info('Check that the version message does not leak the local address of the node')
|
||||
p2p_version_store = self.nodes[0].add_p2p_connection(P2PVersionStore())
|
||||
@ -135,13 +152,8 @@ class P2PLeakTest(BitcoinTestFramework):
|
||||
|
||||
self.log.info('Check that old peers are disconnected')
|
||||
p2p_old_peer = self.nodes[0].add_p2p_connection(P2PInterface(), send_version=False, wait_for_verack=False)
|
||||
old_version_msg = msg_version()
|
||||
old_version_msg.nVersion = 31799
|
||||
old_version_msg.strSubVer = P2P_SUBVERSION
|
||||
old_version_msg.nServices = P2P_SERVICES
|
||||
old_version_msg.relay = P2P_VERSION_RELAY
|
||||
with self.nodes[0].assert_debug_log(['peer=3 using obsolete version 31799; disconnecting']):
|
||||
p2p_old_peer.send_message(old_version_msg)
|
||||
p2p_old_peer.send_message(self.create_old_version(31799))
|
||||
p2p_old_peer.wait_for_disconnect()
|
||||
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user