sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-24 19:42:46 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat: hide deprecated RPC from help and add TODOes to remove them

Browse Source
This commit is contained in:
Konstantin Akimov 2024-12-11 17:02:16 +07:00
parent 05732aceaf
commit 59ddac5656
No known key found for this signature in database
GPG Key ID: 2176C4A5D01EA524
3 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/rpc/coinjoin.cpp
View File

@ -365,6 +365,7 @@ static RPCHelpMan coinjoinsalt_set()
} }
#endif // ENABLE_WALLET #endif // ENABLE_WALLET
// TODO: remove it completely
static RPCHelpMan getpoolinfo() static RPCHelpMan getpoolinfo()
{ {
return RPCHelpMan{"getpoolinfo", return RPCHelpMan{"getpoolinfo",
@ -469,7 +470,6 @@ void RegisterCoinJoinRPCCommands(CRPCTable &t)
static const CRPCCommand commands[] = static const CRPCCommand commands[] =
{ // category actor (function) { // category actor (function)
// --------------------- ----------------------- // --------------------- -----------------------
{ "dash", &getpoolinfo, },
{ "dash", &getcoinjoininfo, }, { "dash", &getcoinjoininfo, },
#ifdef ENABLE_WALLET #ifdef ENABLE_WALLET
{ "dash", &coinjoin, }, { "dash", &coinjoin, },
@ -480,6 +480,8 @@ static const CRPCCommand commands[] =
{ "dash", &coinjoinsalt_generate, }, { "dash", &coinjoinsalt_generate, },
{ "dash", &coinjoinsalt_get, }, { "dash", &coinjoinsalt_get, },
{ "dash", &coinjoinsalt_set, }, { "dash", &coinjoinsalt_set, },
{ "hidden", &getpoolinfo, },
#endif // ENABLE_WALLET #endif // ENABLE_WALLET
}; };
// clang-format on // clang-format on

8
src/rpc/masternode.cpp
View File

@ -133,6 +133,7 @@ static UniValue GetNextMasternodeForPayment(const CChain& active_chain, CDetermi
return obj; return obj;
} }
// TODO: drop it
static RPCHelpMan masternode_winner() static RPCHelpMan masternode_winner()
{ {
return RPCHelpMan{"masternode winner", return RPCHelpMan{"masternode winner",
@ -153,6 +154,7 @@ static RPCHelpMan masternode_winner()
}; };
} }
// TODO: drop it
static RPCHelpMan masternode_current() static RPCHelpMan masternode_current()
{ {
return RPCHelpMan{"masternode current", return RPCHelpMan{"masternode current",
@ -226,7 +228,7 @@ static RPCHelpMan masternode_status()
} }
UniValue mnObj(UniValue::VOBJ); UniValue mnObj(UniValue::VOBJ);
// keep compatibility with legacy status for now (might get deprecated/removed later) // keep compatibility with legacy status for now (TODO: get deprecated/removed later)
mnObj.pushKV("outpoint", node.mn_activeman->GetOutPoint().ToStringShort()); mnObj.pushKV("outpoint", node.mn_activeman->GetOutPoint().ToStringShort());
mnObj.pushKV("service", node.mn_activeman->GetService().ToStringAddrPort()); mnObj.pushKV("service", node.mn_activeman->GetService().ToStringAddrPort());
auto dmn = CHECK_NONFATAL(node.dmnman)->GetListAtChainTip().GetMN(node.mn_activeman->GetProTxHash()); auto dmn = CHECK_NONFATAL(node.dmnman)->GetListAtChainTip().GetMN(node.mn_activeman->GetProTxHash());
@ -749,8 +751,8 @@ static const CRPCCommand commands[] =
{ "dash", &masternode_status, }, { "dash", &masternode_status, },
{ "dash", &masternode_payments, }, { "dash", &masternode_payments, },
{ "dash", &masternode_winners, }, { "dash", &masternode_winners, },
{ "dash", &masternode_current, }, { "hidden", &masternode_current, },
{ "dash", &masternode_winner, }, { "hidden", &masternode_winner, },
}; };
// clang-format on // clang-format on
for (const auto& command : commands) { for (const auto& command : commands) {

2
src/rpc/net.cpp
View File

@ -241,7 +241,7 @@ static RPCHelpMan getpeerinfo()
obj.pushKV("masternode", stats.m_masternode_connection); obj.pushKV("masternode", stats.m_masternode_connection);
if (fStateStats) { if (fStateStats) {
if (IsDeprecatedRPCEnabled("banscore")) { if (IsDeprecatedRPCEnabled("banscore")) {
// banscore is deprecated in v21 for removal in v22 // TODO: banscore is deprecated in v21 for removal in v22, maybe impossible due to usages in p2p_quorum_data.py
obj.pushKV("banscore", statestats.m_misbehavior_score); obj.pushKV("banscore", statestats.m_misbehavior_score);
} }
obj.pushKV("startingheight", statestats.m_starting_height); obj.pushKV("startingheight", statestats.m_starting_height);