privatesend: Drop redundant CBLSSignature.IsValid() checks (#3866)

It's checked in VerifyInsecure already
This commit is contained in:
dustinface 2020-12-11 00:10:40 +01:00 committed by GitHub
parent cf64339517
commit 5c5340a728
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -63,7 +63,7 @@ bool CPrivateSendQueue::CheckSignature(const CBLSPublicKey& blsPubKey) const
CBLSSignature sig; CBLSSignature sig;
sig.SetBuf(vchSig); sig.SetBuf(vchSig);
if (!sig.IsValid() || !sig.VerifyInsecure(blsPubKey, hash)) { if (!sig.VerifyInsecure(blsPubKey, hash)) {
LogPrint(BCLog::PRIVATESEND, "CPrivateSendQueue::CheckSignature -- VerifyInsecure() failed\n"); LogPrint(BCLog::PRIVATESEND, "CPrivateSendQueue::CheckSignature -- VerifyInsecure() failed\n");
return false; return false;
} }
@ -113,7 +113,7 @@ bool CPrivateSendBroadcastTx::CheckSignature(const CBLSPublicKey& blsPubKey) con
CBLSSignature sig; CBLSSignature sig;
sig.SetBuf(vchSig); sig.SetBuf(vchSig);
if (!sig.IsValid() || !sig.VerifyInsecure(blsPubKey, hash)) { if (!sig.VerifyInsecure(blsPubKey, hash)) {
LogPrint(BCLog::PRIVATESEND, "CPrivateSendBroadcastTx::CheckSignature -- VerifyInsecure() failed\n"); LogPrint(BCLog::PRIVATESEND, "CPrivateSendBroadcastTx::CheckSignature -- VerifyInsecure() failed\n");
return false; return false;
} }