make optionsmodel query real proxy state for ::data()

- don't rely on the QSettings for cases ProxyUse and ProxySocksVersion and
  query the real values via the GetProxy() call
- add a missing "succesful =" for case ProxyUse in ::setData()
This commit is contained in:
Philip Kaufmann 2012-10-02 13:30:44 +02:00
parent 43de64949c
commit 5e5c102f2f

View File

@ -142,8 +142,10 @@ QVariant OptionsModel::data(const QModelIndex & index, int role) const
return settings.value("fUseUPnP", GetBoolArg("-upnp", true)); return settings.value("fUseUPnP", GetBoolArg("-upnp", true));
case MinimizeOnClose: case MinimizeOnClose:
return QVariant(fMinimizeOnClose); return QVariant(fMinimizeOnClose);
case ProxyUse: case ProxyUse: {
return settings.value("fUseProxy", false); proxyType proxy;
return QVariant(GetProxy(NET_IPV4, proxy));
}
case ProxyIP: { case ProxyIP: {
proxyType proxy; proxyType proxy;
if (GetProxy(NET_IPV4, proxy)) if (GetProxy(NET_IPV4, proxy))
@ -158,8 +160,13 @@ QVariant OptionsModel::data(const QModelIndex & index, int role) const
else else
return QVariant(9050); return QVariant(9050);
} }
case ProxySocksVersion: case ProxySocksVersion: {
return settings.value("nSocksVersion", 5); proxyType proxy;
if (GetProxy(NET_IPV4, proxy))
return QVariant(proxy.second);
else
return QVariant(5);
}
case Fee: case Fee:
return QVariant(nTransactionFee); return QVariant(nTransactionFee);
case DisplayUnit: case DisplayUnit:
@ -203,7 +210,7 @@ bool OptionsModel::setData(const QModelIndex & index, const QVariant & value, in
break; break;
case ProxyUse: case ProxyUse:
settings.setValue("fUseProxy", value.toBool()); settings.setValue("fUseProxy", value.toBool());
ApplyProxySettings(); successful = ApplyProxySettings();
break; break;
case ProxyIP: { case ProxyIP: {
proxyType proxy; proxyType proxy;