mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
Merge #11003: Docs: Capitalize bullet points in CONTRIBUTING guide
13b1e9a16
Capitalize bullet points in CONTRIBUTING guide (Evan Klitzke)
Pull request description:
English grammar dictates that these bullet points should be capitalized.
This also makes the capitalization style consistent with the rest of the
document, e.g. the "Decision Making Process" section.
Tree-SHA512: 59f5a8941180ff3862ba63d364c27fd83d2e144299a71b2e784d58f806e8a02d7951dcc80fcc7152d0c78c2d1f5a22db1236af7ea6b9abece8dbe93533e4b65c
This commit is contained in:
parent
cd490905be
commit
5f2aef826f
@ -170,13 +170,13 @@ judge the general consensus of contributors.
|
|||||||
|
|
||||||
In general, all pull requests must:
|
In general, all pull requests must:
|
||||||
|
|
||||||
- have a clear use case, fix a demonstrable bug or serve the greater good of
|
- Have a clear use case, fix a demonstrable bug or serve the greater good of
|
||||||
the project (for example refactoring for modularisation);
|
the project (for example refactoring for modularisation);
|
||||||
- be well peer reviewed;
|
- Be well peer reviewed;
|
||||||
- have unit tests and functional tests where appropriate;
|
- Have unit tests and functional tests where appropriate;
|
||||||
- follow [code style guidelines](/doc/developer-notes.md);
|
- Follow [code style guidelines](/doc/developer-notes.md);
|
||||||
- not break the existing test suite;
|
- Not break the existing test suite;
|
||||||
- where bugs are fixed, where possible, there should be unit tests
|
- Where bugs are fixed, where possible, there should be unit tests
|
||||||
demonstrating the bug and also proving the fix. This helps prevent regression.
|
demonstrating the bug and also proving the fix. This helps prevent regression.
|
||||||
|
|
||||||
Patches that change Dash consensus rules are considerably more involved than
|
Patches that change Dash consensus rules are considerably more involved than
|
||||||
|
@ -90,7 +90,7 @@ on nodes 2 and up.
|
|||||||
|
|
||||||
- Implement a (generator) function called `get_tests()` which yields `TestInstance`s.
|
- Implement a (generator) function called `get_tests()` which yields `TestInstance`s.
|
||||||
Each `TestInstance` consists of:
|
Each `TestInstance` consists of:
|
||||||
- a list of `[object, outcome, hash]` entries
|
- A list of `[object, outcome, hash]` entries
|
||||||
* `object` is a `CBlock`, `CTransaction`, or
|
* `object` is a `CBlock`, `CTransaction`, or
|
||||||
`CBlockHeader`. `CBlock`'s and `CTransaction`'s are tested for
|
`CBlockHeader`. `CBlock`'s and `CTransaction`'s are tested for
|
||||||
acceptance. `CBlockHeader`s can be used so that the test runner can deliver
|
acceptance. `CBlockHeader`s can be used so that the test runner can deliver
|
||||||
|
Loading…
Reference in New Issue
Block a user