sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore: exclude underscore placeholder from shadowing linter warnings

Browse Source 
Bitcoin uses underscore in util/translation.h for translatable strings
but underscores are also a placeholder used in multiple languages, incl.
C++. The next commit will be introducing backports, one of them will be
placing util/translation.h into validation.h, which is a header used by
Dash-specific code.

This causes a conflict between the normal usage of underscore as a
placeholder and Bitcoin's usage of it as a function name, which is
reported by the Dash-specific linter. We need to exclude shadowing
warnings from the linter to account for this.
This commit is contained in:
Kittywhiskers Van Gogh 2024-07-04 11:51:31 +00:00
parent 5f9f05edbc
commit 6df927fc60
No known key found for this signature in database
GPG Key ID: 30CD0C065E5C4AAD
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/lint/lint-cppcheck-dash.sh
View File

@ -21,7 +21,7 @@ ENABLED_CHECKS=(
"Variable '.*' is assigned a value that is never used."
"Unused variable"
"The function '.*' overrides a function in a base class but is not marked with a 'override' specifier."
# Enabale to catch all warnings
# Enable to catch all warnings
".*"
)
@ -34,13 +34,14 @@ IGNORED_WARNINGS=(
"src/rpc/.*cpp:.*: note: Function pointer used here."
"src/masternode/sync.cpp:.*: warning: Variable 'pnode' can be declared as pointer to const \[constVariableReference\]"
"src/wallet/bip39.cpp.*: warning: The scope of the variable 'ssCurrentWord' can be reduced. \[variableScope\]"
"src/.*:.*: warning: Local variable '_' shadows outer function \[shadowFunction\]"
"src/stacktraces.cpp:.*: .*: Parameter 'info' can be declared as pointer to const"
"src/stacktraces.cpp:.*: note: You might need to cast the function pointer here"
"[note|warning]: Return value 'state.Invalid(.*)' is always false"
"note: Calling function 'Invalid' returns 0"
"note: Shadow variable"
# General catchall, for some reason any value named 'hash' is viewed as never used.
"Variable 'hash' is assigned a value that is never used."