merge bitcoin#26040: comment "add only reachable addresses to addrman"

This commit is contained in:
Kittywhiskers Van Gogh 2022-09-07 21:30:50 +03:00
parent 1adb635ec6
commit 79a550ec15
No known key found for this signature in database
GPG Key ID: 30CD0C065E5C4AAD

View File

@ -2654,6 +2654,14 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect, CDe
if (add_fixed_seeds_now) {
std::vector<CAddress> seed_addrs{ConvertSeeds(Params().FixedSeeds())};
// We will not make outgoing connections to peers that are unreachable
// (e.g. because of -onlynet configuration).
// Therefore, we do not add them to addrman in the first place.
// Note that if you change -onlynet setting from one network to another,
// peers.dat will contain only peers of unreachable networks and
// manual intervention will be needed (either delete peers.dat after
// configuration change or manually add some reachable peer using addnode),
// see <https://github.com/bitcoin/bitcoin/issues/26035> for details.
seed_addrs.erase(std::remove_if(seed_addrs.begin(), seed_addrs.end(),
[](const CAddress& addr) { return !IsReachable(addr); }),
seed_addrs.end());