From 7ca61abed0cda843374b116dbf5acfb7c20920c0 Mon Sep 17 00:00:00 2001 From: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Date: Fri, 29 Sep 2023 07:53:22 -0500 Subject: [PATCH] refactor: remove some now unneeded cppcheck suppressions (#5589) ## Issue being fixed or feature implemented Unneeded suppressions were present ## What was done? Removed them ## How Has This Been Tested? Running linter ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ --- test/lint/lint-cppcheck-dash.sh | 8 -------- 1 file changed, 8 deletions(-) diff --git a/test/lint/lint-cppcheck-dash.sh b/test/lint/lint-cppcheck-dash.sh index 3dd1aaa4a9..b6776c9897 100755 --- a/test/lint/lint-cppcheck-dash.sh +++ b/test/lint/lint-cppcheck-dash.sh @@ -27,17 +27,9 @@ ENABLED_CHECKS=( IGNORED_WARNINGS=( "src/bls/bls.h:.* Struct 'CBLSIdImplicit' has a constructor with 1 argument that is not explicit." - "src/llmq/dkgsessionmgr.h:.* warning: struct member 'ContributionsCacheEntry::entryTime' is never used." - "src/llmq/instantsend.h:.* warning: struct member 'NonLockedTxInfo::pindexMined' is never used." "src/rpc/masternode.cpp:.*:21: warning: Consider using std::copy algorithm instead of a raw loop." # UniValue doesn't support std::copy - "src/spork.h:.* warning: struct member 'CSporkDef::defaultValue' is never used." - "src/test/dip0020opcodes_tests.cpp:.* warning: There is an unknown macro here somewhere. Configuration is required. If BOOST_FIXTURE_TEST_SUITE is a macro then please configure it." - "src/ctpl_stl.h:.*22: warning: Dereferencing '_f' after it is deallocated / released" "src/cachemultimap.h:.*: warning: Variable 'mapIt' can be declared as reference to const" "src/evo/simplifiedmns.cpp:.*:20: warning: Consider using std::copy algorithm instead of a raw loop." -# "src/llmq/snapshot.cpp:.*:17: warning: Consider using std::copy algorithm instead of a raw loop." -# "src/llmq/snapshot.cpp:.*:18: warning: Consider using std::copy algorithm instead of a raw loop." - # General catchall, for some reason any value named 'hash' is viewed as never used. "Variable 'hash' is assigned a value that is never used."