From 7f83db0d0cb09eb6024c40d488e30a9efbd41aa1 Mon Sep 17 00:00:00 2001 From: fanquake Date: Thu, 24 Aug 2023 10:35:57 +0100 Subject: [PATCH] Merge bitcoin/bitcoin#28332: test: previous releases: speed up fetching sources with shallow clone 360ac64b90ee16cc24bd4c574ec7e11760515a79 test: previous releases: speed up fetching sources with shallow clone (Sebastian Falbesoner) Pull request description: For the sake of building previous releases, fetching the whole history of the repository for each version seems to be overkill as it takes much more time, bandwidth and disk space than necessary. Create a shallow clone instead with history truncated to the one commit of the version tag, which is directly checked out in the same command. This has the nice side-effect that we can remove the extra `git checkout` step after as it's not needed anymore. Note that it might look confusing to pass a _tag_ to a parameter named `--branch`, but the git-clone manpage explicitly states that this is supported. ACKs for top commit: MarcoFalke: lgtm ACK 360ac64b90ee16cc24bd4c574ec7e11760515a79 Tree-SHA512: c885a695c1ea90895cf7a785540c24e8ef8d1d9ea78db28143837240586beb6dfb985b8b0b542d2f64e2f0ffdca7c65fc3d55f44b5e1b22cc5535bc044566f86 --- test/get_previous_releases.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/get_previous_releases.py b/test/get_previous_releases.py index 0ad41648de..19377e7596 100755 --- a/test/get_previous_releases.py +++ b/test/get_previous_releases.py @@ -212,14 +212,11 @@ def build_release(tag, args) -> int: print('Tag {} not found'.format(tag)) return 1 ret = subprocess.run([ - 'git', 'clone', githubUrl, tag + 'git', 'clone', f'--branch={tag}', '--depth=1', githubUrl, tag ]).returncode if ret: return ret with pushd(tag): - ret = subprocess.run(['git', 'checkout', tag]).returncode - if ret: - return ret host = args.host if args.depends: with pushd('depends'):