From 8490bf4b03eebbcd008110cd0d8dd2bbb2cb58f9 Mon Sep 17 00:00:00 2001 From: fanquake Date: Tue, 22 Aug 2023 09:52:38 +0100 Subject: [PATCH] Merge bitcoin/bitcoin#28288: test: fix 'unknown named parameter' test in `wallet_basic` 452c094449de00f3640e6e0763366e7603375825 test: fix 'unknown named parameter' test in `wallet_basic` (brunoerg) Pull request description: This PR removes loop when testing an unknown named parameter. They don't have any effect. ACKs for top commit: jonatack: ACK 452c094449de00f3640e6e0763366e7603375825 theStack: re-ACK 452c094449de00f3640e6e0763366e7603375825 Tree-SHA512: cf1a37d738bb6fdf9817e7b1d33bc69643dae61e3dbfae5c1e9f26220c55db6f134018dd9a1c65c13869ee58bcb6f3337c5999aabf2614d3126fbc01270705e8 --- test/functional/wallet_basic.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/functional/wallet_basic.py b/test/functional/wallet_basic.py index 9b27dccadb..647073cd80 100755 --- a/test/functional/wallet_basic.py +++ b/test/functional/wallet_basic.py @@ -262,8 +262,7 @@ class WalletTest(BitcoinTestFramework): node_0_bal += amount assert_equal(self.nodes[0].getbalance(), node_0_bal) - for key in ["totalFee", "feeRate"]: - assert_raises_rpc_error(-8, "Unknown named parameter key", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, key=1) + assert_raises_rpc_error(-8, "Unknown named parameter feeRate", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, feeRate=1) # Test setting explicit fee rate just below the minimum. self.log.info("Test sendmany raises 'fee rate too low' if fee_rate of 0.99999999 is passed") @@ -454,9 +453,6 @@ class WalletTest(BitcoinTestFramework): workaround_offset = 1 assert_fee_amount(fee, tx_size - workaround_offset, Decimal(fee_rate_btc_kvb)) - for key in ["totalFee", "feeRate"]: - assert_raises_rpc_error(-8, "Unknown named parameter key", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, key=1) - # Test setting explicit fee rate just below the minimum. self.log.info("Test sendtoaddress raises 'fee rate too low' if fee_rate of 0.99999999 is passed") assert_raises_rpc_error(-6, "Fee rate (0.999 duff/B) is lower than the minimum fee rate setting (1.000 duff/B)",