From 874ef8cda231eebde408263874a28e465de50bb6 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Tue, 17 Sep 2024 17:46:12 +0300 Subject: [PATCH] fix: mine_quorum_no_checks -> mine_quorum_less_checks: do some checks to make sure quorums are mined correctly --- test/functional/feature_llmq_simplepose.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/functional/feature_llmq_simplepose.py b/test/functional/feature_llmq_simplepose.py index c93f503b0f..6ca819968a 100755 --- a/test/functional/feature_llmq_simplepose.py +++ b/test/functional/feature_llmq_simplepose.py @@ -92,10 +92,10 @@ class LLMQSimplePoSeTest(DashTestFramework): for mn in self.mninfo: assert not self.check_punished(mn) and not self.check_banned(mn) - def mine_quorum_no_check(self, expected_good_nodes, mninfos_online): + def mine_quorum_less_checks(self, expected_good_nodes, mninfos_online): # Unlike in mine_quorum we skip most of the checks and only care about - # nodes moving forward from phase to phase and the fact that the quorum is actually mined. - self.log.info("Mining a quorum with no checks") + # nodes moving forward from phase to phase correctly and the fact that the quorum is actually mined. + self.log.info("Mining a quorum with less checks") nodes = [self.nodes[0]] + [mn.node for mn in mninfos_online] # move forward to next DKG @@ -112,7 +112,7 @@ class LLMQSimplePoSeTest(DashTestFramework): self.move_blocks(nodes, 2) self.log.info("Waiting for phase 2 (contribute)") - self.wait_for_quorum_phase(q, 2, expected_good_nodes, None, 0, mninfos_online) + self.wait_for_quorum_phase(q, 2, expected_good_nodes, "receivedContributions", expected_good_nodes, mninfos_online) self.move_blocks(nodes, 2) self.log.info("Waiting for phase 3 (complain)") @@ -124,7 +124,7 @@ class LLMQSimplePoSeTest(DashTestFramework): self.move_blocks(nodes, 2) self.log.info("Waiting for phase 5 (commit)") - self.wait_for_quorum_phase(q, 5, expected_good_nodes, None, 0, mninfos_online) + self.wait_for_quorum_phase(q, 5, expected_good_nodes, "receivedPrematureCommitments", expected_good_nodes, mninfos_online) self.move_blocks(nodes, 2) self.log.info("Waiting for phase 6 (mining)") @@ -175,7 +175,7 @@ class LLMQSimplePoSeTest(DashTestFramework): # 6th time is when it should be banned for sure. for _ in range(6): self.reset_probe_timeouts() - self.mine_quorum_no_check(expected_contributors - 1, mninfos_online) + self.mine_quorum_less_checks(expected_contributors - 1, mninfos_online) assert self.check_banned(mn)