Merge bitcoin/bitcoin#23072: log: Remove unnecessary timing of Callbacks bench

ab278007991b912299eaf794d87a636423521d27 log: Remove unnecessary timing logs for Callbacks bench (Douglas Chimento)

Pull request description:

  Logging of Callbacks are no longer needed and records times that are not relevant for performance analysis.
  resolves #23071

ACKs for top commit:
  laanwj:
    Thanks. re-ACK ab278007991b912299eaf794d87a636423521d27
  jonatack:
    Code review ACK ab278007991b912299eaf794d87a636423521d27

Tree-SHA512: be1ea780c4db9407a8799065a8824b9d3610abac72af5907809ed62d493d5a54e65735de45ec5fdd0edb85ef21ec6036105abe8ca00093942980f6f92e7fec50
This commit is contained in:
merge-script 2021-09-23 15:07:16 +02:00 committed by Vijay
parent d290df38ed
commit 945ff0358c
No known key found for this signature in database
GPG Key ID: 47820EC166FDF549

View File

@ -1838,7 +1838,6 @@ static int64_t nTimeDashSpecific = 0;
static int64_t nTimeConnect = 0;
static int64_t nTimeIndexConnect = 0;
static int64_t nTimeIndexWrite = 0;
static int64_t nTimeCallbacks = 0;
static int64_t nTimeTotal = 0;
static int64_t nBlocksTotal = 0;
@ -2293,9 +2292,6 @@ bool CChainState::ConnectBlock(const CBlock& block, BlockValidationState& state,
uiInterface.NotifyMasternodeListChanged(mnlu.new_list, pindex);
}
int64_t nTime8 = GetTimeMicros(); nTimeCallbacks += nTime8 - nTime5;
LogPrint(BCLog::BENCHMARK, " - Callbacks: %.2fms [%.2fs (%.2fms/blk)]\n", MILLI * (nTime8 - nTime5), nTimeCallbacks * MICRO, nTimeCallbacks * MILLI / nBlocksTotal);
::g_stats_client->timing("ConnectBlock_ms", (nTime8 - nTimeStart) / 1000, 1.0f);
::g_stats_client->gauge("blocks.tip.SizeBytes", ::GetSerializeSize(block, PROTOCOL_VERSION), 1.0f);
::g_stats_client->gauge("blocks.tip.Height", m_chain.Height(), 1.0f);