From 95156b7d1caf53d986acece0d4af2406627539d5 Mon Sep 17 00:00:00 2001 From: thephez Date: Thu, 11 May 2023 21:19:45 -0400 Subject: [PATCH] chore: update dash_hash install and instructions (#5291) ## Issue being fixed or feature implemented Install of dash_hash will change once https://github.com/dashpay/dash_hash/pull/17/ is merged ## What was done? - Changed install instructions to match new install in dash_hash README - Updated Dockerfile to install correctly ## How Has This Been Tested? N/A ## Breaking Changes None ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation --- contrib/containers/ci/Dockerfile | 2 +- test/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/containers/ci/Dockerfile b/contrib/containers/ci/Dockerfile index 3a76fb35da..45aeb57ff8 100644 --- a/contrib/containers/ci/Dockerfile +++ b/contrib/containers/ci/Dockerfile @@ -45,7 +45,7 @@ RUN pip3 install \ # dash_hash ARG DASH_HASH_VERSION=1.4.0 RUN git clone --depth 1 --no-tags --branch=${DASH_HASH_VERSION} https://github.com/dashpay/dash_hash -RUN cd dash_hash && python3 setup.py install +RUN cd dash_hash && pip3 install -r requirements.txt . ARG USER_ID=1000 ARG GROUP_ID=1000 diff --git a/test/README.md b/test/README.md index 16a35bb272..f1a869eb1b 100644 --- a/test/README.md +++ b/test/README.md @@ -27,7 +27,7 @@ Before tests can be run locally, Dash Core must be built. See the [building ins Many Dash specific tests require dash_hash. To install it: - Clone the repo `git clone https://github.com/dashpay/dash_hash` -- Install dash_hash `cd dash_hash && python3 setup.py install` +- Install dash_hash `cd dash_hash && pip3 install -r requirements.txt .` The ZMQ functional test requires a python ZMQ library. To install it: