From 999923e4bbc62920810d4d149a4938cfd657408a Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Tue, 20 Jun 2017 13:54:10 +0200 Subject: [PATCH] [qa] util: Check return code after closing bitcoind proc This has no effect on the outcome of test cases, but prints shorter and less confusing tracebacks on fails. I.e. does not print an obvious "ConnectionRefusedError" when shutting down the nodes due to an invalid return code. --- test/functional/test_framework/util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py index 2b0f32c2b6..8a2ac015fc 100644 --- a/test/functional/test_framework/util.py +++ b/test/functional/test_framework/util.py @@ -300,8 +300,8 @@ def _stop_node(node, i): except http.client.CannotSendRequest as e: logger.exception("Unable to stop node") return_code = bitcoind_processes[i].wait(timeout=BITCOIND_PROC_WAIT_TIMEOUT) - assert_equal(return_code, 0) del bitcoind_processes[i] + assert_equal(return_code, 0) def _stop_nodes(nodes): """Stop multiple bitcoind test nodes