sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

HDWallet error/warning message fixes

Browse Source
This commit is contained in:
Alexander Block 2017-09-15 12:48:40 +02:00
parent 298224b3b7
commit 9dbda86cb1
2 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/init.cpp
View File

@ -1115,6 +1115,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
#ifdef ENABLE_WALLET
if (!CWallet::ParameterInteraction())
return false;
std::string strWalletFile = GetArg("-wallet", DEFAULT_WALLET_DAT);
#endif // ENABLE_WALLET
fIsBareMultisigStd = GetBoolArg("-permitbaremultisig", DEFAULT_PERMIT_BAREMULTISIG);

24
src/wallet/wallet.cpp
View File

@ -4524,8 +4524,7 @@ bool CWallet::InitLoadWallet()
if (GetBoolArg("-usehd", DEFAULT_USE_HD_WALLET) && !walletInstance->IsHDEnabled()) {
if (GetArg("-mnemonicpassphrase", "").size() > 256) {
errorString += _("Mnemonic passphrase is too long, must be at most 256 characters");
return NULL;
return UIError(_("Mnemonic passphrase is too long, must be at most 256 characters"));
}
// generate a new master key
walletInstance->GenerateNewHDChain();
@ -4548,13 +4547,10 @@ bool CWallet::InitLoadWallet()
std::string strBackupError;
if(!AutoBackupWallet(walletInstance, "", strBackupWarning, strBackupError)) {
if (!strBackupWarning.empty()) {
if (!warningString.empty())
warningString += "\n";
warningString += strBackupWarning;
UIWarning(strBackupWarning);
}
if (!strBackupError.empty()) {
errorString += strBackupError;
return NULL;
return UIError(strBackupError);
}
}
@ -4562,22 +4558,18 @@ bool CWallet::InitLoadWallet()
else if (mapArgs.count("-usehd")) {
bool useHD = GetBoolArg("-usehd", DEFAULT_USE_HD_WALLET);
if (walletInstance->IsHDEnabled() && !useHD) {
errorString += strprintf(_("Error loading %s: You can't disable HD on a already existing HD wallet"),
strWalletFile);
return NULL;
return UIError(strprintf(_("Error loading %s: You can't disable HD on a already existing HD wallet"),
walletInstance->strWalletFile));
}
if (!walletInstance->IsHDEnabled() && useHD) {
errorString += strprintf(_("Error loading %s: You can't enable HD on a already existing non-HD wallet"),
strWalletFile);
return NULL;
return UIError(strprintf(_("Error loading %s: You can't enable HD on a already existing non-HD wallet"),
walletInstance->strWalletFile));
}
}
// Warn user every time he starts non-encrypted HD wallet
if (GetBoolArg("-usehd", DEFAULT_USE_HD_WALLET) && !walletInstance->IsLocked()) {
if (!warningString.empty())
warningString += "\n";
warningString += _("Make sure to encrypt your wallet and delete all non-encrypted backups after you verified that wallet works!");
UIWarning(_("Make sure to encrypt your wallet and delete all non-encrypted backups after you verified that wallet works!"));
}
LogPrintf(" wallet %15dms\n", GetTimeMillis() - nStart);