sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

stats: stop using error codes, switch over to bool

Browse Source
This commit is contained in:
Kittywhiskers Van Gogh 2024-09-10 15:38:11 +00:00
parent 1a81979c1e
commit 9f96723774
No known key found for this signature in database
GPG Key ID: 30CD0C065E5C4AAD
2 changed files with 32 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/statsd_client.cpp
View File

@ -106,44 +106,45 @@ void StatsdClient::cleanup(std::string& key)
}
}
int StatsdClient::dec(const std::string& key, float sample_rate)
bool StatsdClient::dec(const std::string& key, float sample_rate)
{
return count(key, -1, sample_rate);
}
int StatsdClient::inc(const std::string& key, float sample_rate)
bool StatsdClient::inc(const std::string& key, float sample_rate)
{
return count(key, 1, sample_rate);
}
int StatsdClient::count(const std::string& key, int64_t value, float sample_rate)
bool StatsdClient::count(const std::string& key, int64_t value, float sample_rate)
{
return send(key, value, "c", sample_rate);
}
int StatsdClient::gauge(const std::string& key, int64_t value, float sample_rate)
bool StatsdClient::gauge(const std::string& key, int64_t value, float sample_rate)
{
return send(key, value, "g", sample_rate);
}
int StatsdClient::gaugeDouble(const std::string& key, double value, float sample_rate)
bool StatsdClient::gaugeDouble(const std::string& key, double value, float sample_rate)
{
return sendDouble(key, value, "g", sample_rate);
}
int StatsdClient::timing(const std::string& key, int64_t ms, float sample_rate)
bool StatsdClient::timing(const std::string& key, int64_t ms, float sample_rate)
{
return send(key, ms, "ms", sample_rate);
}
int StatsdClient::send(std::string key, int64_t value, const std::string& type, float sample_rate)
bool StatsdClient::send(std::string key, int64_t value, const std::string& type, float sample_rate)
{
if (!m_sock) {
return -3;
return false;
}
if (!ShouldSend(sample_rate)) {
return 0;
// Not our turn to send but report that we have
return true;
}
// partition stats by node name if set
@ -160,14 +161,15 @@ int StatsdClient::send(std::string key, int64_t value, const std::string& type,
return send(buf);
}
int StatsdClient::sendDouble(std::string key, double value, const std::string& type, float sample_rate)
bool StatsdClient::sendDouble(std::string key, double value, const std::string& type, float sample_rate)
{
if (!m_sock) {
return -3;
return false;
}
if (!ShouldSend(sample_rate)) {
return 0;
// Not our turn to send but report that we have
return true;
}
// partition stats by node name if set
@ -184,7 +186,7 @@ int StatsdClient::sendDouble(std::string key, double value, const std::string& t
return send(buf);
}
int StatsdClient::send(const std::string& message)
bool StatsdClient::send(const std::string& message)
{
assert(m_sock);
@ -192,9 +194,9 @@ int StatsdClient::send(const std::string& message)
reinterpret_cast<struct sockaddr*>(&m_server.first), m_server.second) == SOCKET_ERROR) {
LogPrintf("ERROR: Unable to send message (sendto() returned error %s), host=%s:%d\n",
NetworkErrorString(WSAGetLastError()), m_host, m_port);
return -1;
return false;
}
return 0;
return true;
}
} // namespace statsd

35
src/statsd_client.h
View File

@ -31,32 +31,27 @@ class StatsdClient {
bool enabled);
public:
int inc(const std::string& key, float sample_rate = 1.f);
int dec(const std::string& key, float sample_rate = 1.f);
int count(const std::string& key, int64_t value, float sample_rate = 1.f);
int gauge(const std::string& key, int64_t value, float sample_rate = 1.f);
int gaugeDouble(const std::string& key, double value, float sample_rate = 1.f);
int timing(const std::string& key, int64_t ms, float sample_rate = 1.f);
public:
/**
* (Low Level Api) manually send a message
* which might be composed of several lines.
*/
int send(const std::string& message);
bool inc(const std::string& key, float sample_rate = 1.f);
bool dec(const std::string& key, float sample_rate = 1.f);
bool count(const std::string& key, int64_t value, float sample_rate = 1.f);
bool gauge(const std::string& key, int64_t value, float sample_rate = 1.f);
bool gaugeDouble(const std::string& key, double value, float sample_rate = 1.f);
bool timing(const std::string& key, int64_t ms, float sample_rate = 1.f);
/* (Low Level Api) manually send a message
* type = "c", "g" or "ms"
*/
int send(std::string key, int64_t value,
const std::string& type, float sample_rate);
int sendDouble(std::string key, double value,
const std::string& type, float sample_rate);
protected:
static void cleanup(std::string& key);
bool send(std::string key, int64_t value, const std::string& type, float sample_rate);
bool sendDouble(std::string key, double value, const std::string& type, float sample_rate);
private:
/**
* (Low Level Api) manually send a message
* which might be composed of several lines.
*/
bool send(const std::string& message);
void cleanup(std::string& key);
bool ShouldSend(float sample_rate);
private: