sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-27 04:52:59 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fail GetTransaction when the block from txindex is not in mapBlockIndex (#3606)

Browse Source 
This indicates a previous crash where the TX made it into the txindex but
the block was not flushed to disk. When dashd is restarted then, there is
a short time where GetTransaction would return a non-existant block, while
callers very often assume that the returned block hash is known.
This commit is contained in:
Alexander Block 2020-07-14 11:22:36 +02:00 committed by pasta
parent 62c3fb5748
commit a170c649b8
No known key found for this signature in database
GPG Key ID: 52527BEDABE87984
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/validation.cpp
View File

@ -977,6 +977,9 @@ bool GetTransaction(const uint256& hash, CTransactionRef& txOut, const Consensus
hashBlock = header.GetHash(); hashBlock = header.GetHash();
if (txOut->GetHash() != hash) if (txOut->GetHash() != hash)
return error("%s: txid mismatch", __func__); return error("%s: txid mismatch", __func__);
if (!mapBlockIndex.count(hashBlock)) {
return error("%s: hashBlock %s not in mapBlockIndex", __func__, hashBlock.ToString());
}
return true; return true;
} }