diff --git a/doc/release-notes-14023.md b/doc/release-notes-14023.md new file mode 100644 index 0000000000..b23c11268b --- /dev/null +++ b/doc/release-notes-14023.md @@ -0,0 +1,8 @@ +Accout API removed +------------------ + +The 'account' API was deprecated in v0.17 and has been fully removed in v0.18. +The 'label' API was introduced in v0.17 as a replacement for accounts. + +See the release notes from v0.17 for a full description of the changes from the +'account' API to the 'label' API. diff --git a/src/Makefile.test.include b/src/Makefile.test.include index 8a6ce2d520..cac31bb6c4 100644 --- a/src/Makefile.test.include +++ b/src/Makefile.test.include @@ -196,7 +196,6 @@ BITCOIN_TESTS =\ if ENABLE_WALLET BITCOIN_TESTS += \ wallet/test/coinjoin_tests.cpp \ - wallet/test/accounting_tests.cpp \ wallet/test/db_tests.cpp \ wallet/test/psbt_wallet_tests.cpp \ wallet/test/wallet_tests.cpp \ diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp index b5e5ea6553..0bb8ea01d2 100644 --- a/src/rpc/client.cpp +++ b/src/rpc/client.cpp @@ -44,8 +44,6 @@ static const CRPCConvertParam vRPCConvertParams[] = { "settxfee", 0, "amount" }, { "getreceivedbyaddress", 1, "minconf" }, { "getreceivedbyaddress", 2, "addlocked" }, - { "getreceivedbyaccount", 1, "minconf" }, - { "getreceivedbyaccount", 2, "addlocked" }, { "getreceivedbylabel", 1, "minconf" }, { "getreceivedbylabel", 2, "addlocked" }, { "listaddressbalances", 0, "minamount" }, @@ -53,10 +51,6 @@ static const CRPCConvertParam vRPCConvertParams[] = { "listreceivedbyaddress", 1, "addlocked" }, { "listreceivedbyaddress", 2, "include_empty" }, { "listreceivedbyaddress", 3, "include_watchonly" }, - { "listreceivedbyaccount", 0, "minconf" }, - { "listreceivedbyaccount", 1, "addlocked" }, - { "listreceivedbyaccount", 2, "include_empty" }, - { "listreceivedbyaccount", 3, "include_watchonly" }, { "listreceivedbylabel", 0, "minconf" }, { "listreceivedbylabel", 1, "addlocked" }, { "listreceivedbylabel", 2, "include_empty" }, @@ -72,17 +66,9 @@ static const CRPCConvertParam vRPCConvertParams[] = { "waitforblockheight", 1, "timeout" }, { "waitforblock", 1, "timeout" }, { "waitfornewblock", 0, "timeout" }, - { "move", 2, "amount" }, - { "move", 3, "minconf" }, - { "sendfrom", 2, "amount" }, - { "sendfrom", 3, "minconf" }, - { "sendfrom", 4, "addlocked" }, { "listtransactions", 1, "count" }, { "listtransactions", 2, "skip" }, { "listtransactions", 3, "include_watchonly" }, - { "listaccounts", 0, "minconf" }, - { "listaccounts", 1, "addlocked" }, - { "listaccounts", 2, "include_watchonly" }, { "walletpassphrase", 1, "timeout" }, { "walletpassphrase", 2, "mixingonly" }, { "getblocktemplate", 0, "template_request" }, diff --git a/src/wallet/rpcdump.cpp b/src/wallet/rpcdump.cpp index bbcfa5d9e3..a4dba8af8d 100644 --- a/src/wallet/rpcdump.cpp +++ b/src/wallet/rpcdump.cpp @@ -1353,7 +1353,7 @@ UniValue importmulti(const JSONRPCRequest& mainRequest) " \"keys\": [\"\", ... ] , (array, optional) Array of strings giving private keys whose corresponding public keys must occur in the output or redeemscript\n" " \"internal\": , (boolean, optional, default: false) Stating whether matching outputs should be treated as not incoming payments aka change\n" " \"watchonly\": , (boolean, optional, default: false) Stating whether matching outputs should be considered watched even when they're not spendable, only allowed if keys are empty\n" - " \"label\":