Merge #16278: tests: Remove unused includes (#4528)

9a841696c1e7147e259e5a387566e461abc144ec tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift)

Pull request description:

  Reduce compilation time and unneccessary recompiles by removing unused includes in tests.

  A subset of #16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in https://github.com/bitcoin/bitcoin/pull/16273#issuecomment-505022643.

ACKs for top commit:
  Sjors:
    ACK 9a84169 on macOS 10.14.5 (I rebased on #16289)

Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
This commit is contained in:
Vijay Manikpuri 2021-11-30 11:23:40 +05:30 committed by GitHub
parent f00a27ec97
commit b0b8b2d2a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
50 changed files with 46 additions and 54 deletions

View File

@ -13,7 +13,6 @@
#include <key.h>
#include <key_io.h>
#include <pubkey.h>
#include <wallet/wallet.h>
#include <QApplication>

View File

@ -31,7 +31,6 @@
#include <QtGlobal>
#include <QtTest/QtTestWidgets>
#include <QtTest/QtTestGui>
#include <new>
#include <string>
#include <univalue.h>

View File

@ -6,7 +6,6 @@
#include <chainparams.h>
#include <consensus/validation.h>
#include <fs.h>
#include <interfaces/node.h>
#include <validation.h>
#include <rpc/register.h>

View File

@ -8,9 +8,6 @@
#include <QObject>
#include <QTest>
#include <txdb.h>
#include <txmempool.h>
class RPCNestedTests : public QObject
{
Q_OBJECT

View File

@ -7,7 +7,6 @@
#include <config/dash-config.h>
#endif
#include <chainparams.h>
#include <interfaces/node.h>
#include <qt/dash.h>
#include <qt/test/apptests.h>

View File

@ -2,9 +2,9 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <util/memory.h>
#include <util/system.h>
#include <support/allocators/secure.h>
#include <test/setup_common.h>
#include <memory>

View File

@ -11,7 +11,6 @@
#include <uint256.h>
#include <arith_uint256.h>
#include <string>
#include <version.h>
#include <test/setup_common.h>
BOOST_FIXTURE_TEST_SUITE(arith_uint256_tests, BasicTestingSetup)

View File

@ -4,9 +4,10 @@
#include <boost/test/unit_test.hpp>
#include <clientversion.h>
#include <key.h>
#include <key_io.h>
#include <uint256.h>
#include <streams.h>
#include <util/system.h>
#include <util/strencodings.h>
#include <test/setup_common.h>

View File

@ -2,6 +2,7 @@
#include <stdlib.h>
#include <chain.h>
#include <rpc/blockchain.h>
#include <test/setup_common.h>

View File

@ -6,7 +6,7 @@
#include <consensus/merkle.h>
#include <chainparams.h>
#include <pow.h>
#include <random.h>
#include <streams.h>
#include <test/setup_common.h>

View File

@ -10,6 +10,7 @@
#include <pow.h>
#include <test/setup_common.h>
#include <script/standard.h>
#include <util/time.h>
#include <validation.h>
#include <boost/test/unit_test.hpp>

View File

@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <sync.h>
#include <util/memory.h>
#include <util/system.h>
#include <util/time.h>
@ -17,8 +18,6 @@
#include <condition_variable>
#include <unordered_set>
#include <memory>
#include <random.h>
BOOST_FIXTURE_TEST_SUITE(checkqueue_tests, TestingSetup)

View File

@ -3,9 +3,11 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <attributes.h>
#include <clientversion.h>
#include <coins.h>
#include <consensus/validation.h>
#include <script/standard.h>
#include <streams.h>
#include <test/setup_common.h>
#include <uint256.h>
#include <undo.h>

View File

@ -4,8 +4,8 @@
#include <dbwrapper.h>
#include <uint256.h>
#include <random.h>
#include <test/setup_common.h>
#include <util/memory.h>
#include <memory>

View File

@ -12,7 +12,9 @@
#include <pow.h>
#include <script/sign.h>
#include <serialize.h>
#include <util/memory.h>
#include <util/system.h>
#include <util/time.h>
#include <validation.h>
#include <test/setup_common.h>

View File

@ -2,8 +2,11 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <clientversion.h>
#include <flatfile.h>
#include <streams.h>
#include <test/setup_common.h>
#include <util/system.h>
#include <boost/test/unit_test.hpp>

View File

@ -5,6 +5,7 @@
#include <fs.h>
#include <test/setup_common.h>
#include <util/getuniquepath.h>
#include <util/system.h>
#include <boost/test/unit_test.hpp>

View File

@ -2,6 +2,7 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <addrdb.h>
#include <addrman.h>
#include <blockencodings.h>
#include <blockfilter.h>
@ -15,8 +16,6 @@
#include <primitives/block.h>
#include <protocol.h>
#include <psbt.h>
#include <pubkey.h>
#include <script/script.h>
#include <script/sign.h>
#include <streams.h>
#include <undo.h>
@ -27,8 +26,6 @@
#include <stdint.h>
#include <unistd.h>
#include <algorithm>
#include <memory>
#include <vector>
#include <test/fuzz/fuzz.h>

View File

@ -5,7 +5,6 @@
#ifndef BITCOIN_TEST_FUZZ_FUZZ_H
#define BITCOIN_TEST_FUZZ_FUZZ_H
#include <functional>
#include <stdint.h>
#include <vector>

View File

@ -3,7 +3,6 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <script/interpreter.h>
#include <script/script.h>
#include <streams.h>
#include <version.h>

View File

@ -2,13 +2,12 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <clientversion.h>
#include <crypto/siphash.h>
#include <hash.h>
#include <util/strencodings.h>
#include <test/setup_common.h>
#include <vector>
#include <boost/test/unit_test.hpp>
BOOST_FIXTURE_TEST_SUITE(hash_tests, BasicTestingSetup)

View File

@ -5,7 +5,6 @@
#include <key.h>
#include <key_io.h>
#include <script/script.h>
#include <uint256.h>
#include <util/system.h>
#include <util/strencodings.h>

View File

@ -5,11 +5,11 @@
#include <txmempool.h>
#include <policy/policy.h>
#include <util/system.h>
#include <util/time.h>
#include <test/setup_common.h>
#include <boost/test/unit_test.hpp>
#include <list>
#include <vector>
BOOST_FIXTURE_TEST_SUITE(mempool_tests, TestingSetup)

View File

@ -12,12 +12,12 @@
#include <miner.h>
#include <policy/policy.h>
#include <pow.h>
#include <pubkey.h>
#include <script/standard.h>
#include <txmempool.h>
#include <uint256.h>
#include <util/strencodings.h>
#include <util/system.h>
#include <util/time.h>
#include <validation.h>
#include <test/setup_common.h>

View File

@ -10,6 +10,7 @@
#include <script/interpreter.h>
#include <script/sign.h>
#include <script/ismine.h>
#include <tinyformat.h>
#include <uint256.h>
#include <test/setup_common.h>

View File

@ -1,17 +1,20 @@
// Copyright (c) 2012-2016 The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <addrdb.h>
#include <addrman.h>
#include <clientversion.h>
#include <test/setup_common.h>
#include <string>
#include <boost/test/unit_test.hpp>
#include <hash.h>
#include <serialize.h>
#include <span.h>
#include <streams.h>
#include <net.h>
#include <netbase.h>
#include <chainparams.h>
#include <util/memory.h>
#include <util/system.h>
#include <util/strencodings.h>
#include <version.h>

View File

@ -7,6 +7,7 @@
#include <txmempool.h>
#include <uint256.h>
#include <util/system.h>
#include <util/time.h>
#include <test/setup_common.h>

View File

@ -5,7 +5,6 @@
#include <chain.h>
#include <chainparams.h>
#include <pow.h>
#include <random.h>
#include <util/system.h>
#include <test/setup_common.h>

View File

@ -11,8 +11,6 @@
#include <test/setup_common.h>
#include <vector>
#include <boost/test/unit_test.hpp>
BOOST_FIXTURE_TEST_SUITE(raii_event_tests, BasicTestingSetup)

View File

@ -11,8 +11,8 @@
#include <interfaces/chain.h>
#include <key_io.h>
#include <netbase.h>
#include <test/setup_common.h>
#include <util/time.h>
#include <boost/algorithm/string.hpp>
#include <boost/test/unit_test.hpp>

View File

@ -6,7 +6,6 @@
#include <keystore.h>
#include <script/ismine.h>
#include <script/script.h>
#include <script/script_error.h>
#include <script/standard.h>
#include <test/setup_common.h>

View File

@ -14,12 +14,12 @@
#include <util/strencodings.h>
#include <rpc/util.h>
#include <test/setup_common.h>
#include <streams.h>
#if defined(HAVE_CONSENSUS_LIB)
#include <script/dashconsensus.h>
#endif
#include <fstream>
#include <stdint.h>
#include <string>
#include <vector>

View File

@ -6,7 +6,6 @@
#ifndef BITCOIN_TEST_SCRIPTNUM10_H
#define BITCOIN_TEST_SCRIPTNUM10_H
#include <algorithm>
#include <limits>
#include <stdexcept>
#include <stdint.h>

View File

@ -6,6 +6,7 @@
#include <streams.h>
#include <hash.h>
#include <test/setup_common.h>
#include <util/strencodings.h>
#include <stdint.h>

View File

@ -13,7 +13,7 @@
#include <index/txindex.h>
#include <init.h>
#include <miner.h>
#include <net_processing.h>
#include <net.h>
#include <noui.h>
#include <pow.h>
#include <rpc/register.h>
@ -21,7 +21,12 @@
#include <script/sigcache.h>
#include <streams.h>
#include <ui_interface.h>
#include <txdb.h>
#include <util/memory.h>
#include <util/strencodings.h>
#include <util/time.h>
#include <validation.h>
#include <validationinterface.h>
#include <util/validation.h>

View File

@ -15,7 +15,6 @@
#include <txdb.h>
#include <txmempool.h>
#include <memory>
#include <type_traits>
#include <boost/thread.hpp>

View File

@ -2,6 +2,7 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <consensus/consensus.h>
#include <consensus/tx_verify.h>
#include <pubkey.h>
#include <key.h>

View File

@ -4,7 +4,6 @@
#include <random.h>
#include <streams.h>
#include <support/allocators/zeroafterfree.h>
#include <test/setup_common.h>
#include <boost/test/unit_test.hpp>

View File

@ -18,6 +18,7 @@
#include <policy/settings.h>
#include <script/script.h>
#include <script/script_error.h>
#include <streams.h>
#include <util/strencodings.h>
#include <map>

View File

@ -3,8 +3,6 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <validation.h>
#include <txmempool.h>
#include <amount.h>
#include <consensus/validation.h>
#include <primitives/transaction.h>
#include <script/script.h>

View File

@ -5,14 +5,10 @@
#include <consensus/validation.h>
#include <key.h>
#include <validation.h>
#include <miner.h>
#include <pubkey.h>
#include <txmempool.h>
#include <random.h>
#include <script/standard.h>
#include <script/sign.h>
#include <test/setup_common.h>
#include <util/time.h>
#include <core_io.h>
#include <keystore.h>
#include <policy/policy.h>

View File

@ -1,19 +1,17 @@
// Copyright (c) 2011-2015 The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <arith_uint256.h>
#include <streams.h>
#include <uint256.h>
#include <version.h>
#include <test/setup_common.h>
#include <boost/test/unit_test.hpp>
#include <stdint.h>
#include <sstream>
#include <iomanip>
#include <limits>
#include <cmath>
#include <string>
#include <stdio.h>
BOOST_FIXTURE_TEST_SUITE(uint256_tests, BasicTestingSetup)

View File

@ -19,8 +19,6 @@
#include <wallet/wallet.h>
#endif
#include <boost/thread.hpp>
const std::string ADDRESS_B58T_UNSPENDABLE = "yXXXXXXXXXXXXXXXXXXXXXXXXXXXVd2rXU";
const std::string ADDRESS_BCRT1_UNSPENDABLE = "bcrt1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq3xueyj";

View File

@ -5,18 +5,19 @@
#include <util/system.h>
#include <clientversion.h>
#include <primitives/transaction.h>
#include <sync.h>
#include <util/getuniquepath.h>
#include <util/strencodings.h>
#include <util/string.h>
#include <util/moneystr.h>
#include <util/time.h>
#include <test/setup_common.h>
#include <util/vector.h>
#include <util/spanparsing.h>
#include <stdint.h>
#include <utility>
#include <thread>
#include <vector>
#ifndef WIN32
#include <signal.h>

View File

@ -11,9 +11,12 @@
#include <pow.h>
#include <random.h>
#include <test/setup_common.h>
#include <util/time.h>
#include <validation.h>
#include <validationinterface.h>
#include <thread>
struct RegtestingSetup : public TestingSetup {
RegtestingSetup() : TestingSetup(CBaseChainParams::REGTEST) {}
};

View File

@ -3,6 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <fs.h>
#include <util/system.h>
#include <wallet/test/init_test_fixture.h>

View File

@ -6,6 +6,7 @@
#include <noui.h>
#include <test/setup_common.h>
#include <util/system.h>
#include <wallet/test/init_test_fixture.h>
#include <init.h>

View File

@ -3,12 +3,10 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <key_io.h>
#include <script/sign.h>
#include <util/strencodings.h>
#include <wallet/psbtwallet.h>
#include <wallet/rpcwallet.h>
#include <wallet/wallet.h>
#include <univalue.h>
#include <boost/test/unit_test.hpp>
#include <test/setup_common.h>

View File

@ -5,7 +5,6 @@
#include <wallet/test/wallet_test_fixture.h>
#include <rpc/server.h>
#include <wallet/db.h>
#include <wallet/rpcwallet.h>
WalletTestingSetup::WalletTestingSetup(const std::string& chainName)

View File

@ -6,9 +6,7 @@
#include <iostream>
#include <memory>
#include <set>
#include <stdint.h>
#include <utility>
#include <vector>
#include <consensus/validation.h>