merge bitcoin#23769: Disallow copies of CChain

This commit is contained in:
Kittywhiskers Van Gogh 2021-12-14 12:39:29 +01:00
parent 5b66688160
commit b4bfacfd24
No known key found for this signature in database
GPG Key ID: 30CD0C065E5C4AAD

View File

@ -59,7 +59,8 @@ public:
READWRITE(VARINT(obj.nTimeLast));
}
void SetNull() {
void SetNull()
{
nBlocks = 0;
nSize = 0;
nUndoSize = 0;
@ -69,14 +70,16 @@ public:
nTimeLast = 0;
}
CBlockFileInfo() {
CBlockFileInfo()
{
SetNull();
}
std::string ToString() const;
/** update statistics (does not update nSize) */
void AddBlock(unsigned int nHeightIn, uint64_t nTimeIn) {
void AddBlock(unsigned int nHeightIn, uint64_t nTimeIn)
{
if (nBlocks == 0 || nHeightFirst > nHeightIn)
nHeightFirst = nHeightIn;
if (nBlocks == 0 || nTimeFirst > nTimeIn)
@ -360,12 +363,14 @@ public:
uint256 hash;
uint256 hashPrev;
CDiskBlockIndex() {
CDiskBlockIndex()
{
hash = uint256();
hashPrev = uint256();
}
explicit CDiskBlockIndex(const CBlockIndex* pindex) : CBlockIndex(*pindex) {
explicit CDiskBlockIndex(const CBlockIndex* pindex) : CBlockIndex(*pindex)
{
hash = (hash == uint256() ? pindex->GetBlockHash() : hash);
hashPrev = (pprev ? pprev->GetBlockHash() : uint256());
}
@ -413,35 +418,45 @@ public:
};
/** An in-memory indexed chain of blocks. */
class CChain {
class CChain
{
private:
std::vector<CBlockIndex*> vChain;
public:
CChain() = default;
CChain(const CChain&) = delete;
CChain& operator=(const CChain&) = delete;
/** Returns the index entry for the genesis block of this chain, or nullptr if none. */
CBlockIndex *Genesis() const {
CBlockIndex* Genesis() const
{
return vChain.size() > 0 ? vChain[0] : nullptr;
}
/** Returns the index entry for the tip of this chain, or nullptr if none. */
CBlockIndex *Tip() const {
CBlockIndex* Tip() const
{
return vChain.size() > 0 ? vChain[vChain.size() - 1] : nullptr;
}
/** Returns the index entry at a particular height in this chain, or nullptr if no such height exists. */
CBlockIndex *operator[](int nHeight) const {
CBlockIndex* operator[](int nHeight) const
{
if (nHeight < 0 || nHeight >= (int)vChain.size())
return nullptr;
return vChain[nHeight];
}
/** Efficiently check whether a block is present in this chain. */
bool Contains(const CBlockIndex *pindex) const {
bool Contains(const CBlockIndex* pindex) const
{
return (*this)[pindex->nHeight] == pindex;
}
/** Find the successor of a block in this chain, or nullptr if the given index is not found or is the tip. */
CBlockIndex *Next(const CBlockIndex *pindex) const {
CBlockIndex* Next(const CBlockIndex* pindex) const
{
if (Contains(pindex))
return (*this)[pindex->nHeight + 1];
else
@ -449,7 +464,8 @@ public:
}
/** Return the maximal height in the chain. Is equal to chain.Tip() ? chain.Tip()->nHeight : -1. */
int Height() const {
int Height() const
{
return vChain.size() - 1;
}