mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 03:52:49 +01:00
rpc: remove keypool replenishment stat and warning for descriptor wallet
This commit is contained in:
parent
1f113587fb
commit
b7c7bff6e0
4
doc/release-notes-6108.md
Normal file
4
doc/release-notes-6108.md
Normal file
@ -0,0 +1,4 @@
|
|||||||
|
RPC changes
|
||||||
|
-----------
|
||||||
|
|
||||||
|
- `getcoinjoininfo` will no longer report `keys_left` and will not incorrectly warn about keypool depletion with descriptor wallets
|
@ -137,7 +137,7 @@ static RPCHelpMan getcoinjoininfo()
|
|||||||
{RPCResult::Type::NUM, "entries_count", "The number of entries in the mixing session"},
|
{RPCResult::Type::NUM, "entries_count", "The number of entries in the mixing session"},
|
||||||
}},
|
}},
|
||||||
}},
|
}},
|
||||||
{RPCResult::Type::NUM, "keys_left", "How many new keys are left since last automatic backup"},
|
{RPCResult::Type::NUM, "keys_left", /* optional */ true, "How many new keys are left since last automatic backup (if applicable)"},
|
||||||
{RPCResult::Type::STR, "warnings", "Warnings if any"},
|
{RPCResult::Type::STR, "warnings", "Warnings if any"},
|
||||||
}},
|
}},
|
||||||
RPCResult{"for masternodes",
|
RPCResult{"for masternodes",
|
||||||
@ -177,9 +177,14 @@ static RPCHelpMan getcoinjoininfo()
|
|||||||
CHECK_NONFATAL(manager != nullptr);
|
CHECK_NONFATAL(manager != nullptr);
|
||||||
manager->GetJsonInfo(obj);
|
manager->GetJsonInfo(obj);
|
||||||
|
|
||||||
obj.pushKV("keys_left", wallet->nKeysLeftSinceAutoBackup);
|
std::string warning_msg{""};
|
||||||
obj.pushKV("warnings", wallet->nKeysLeftSinceAutoBackup < COINJOIN_KEYS_THRESHOLD_WARNING
|
if (wallet->IsLegacy()) {
|
||||||
? "WARNING: keypool is almost depleted!" : "");
|
obj.pushKV("keys_left", wallet->nKeysLeftSinceAutoBackup);
|
||||||
|
if (wallet->nKeysLeftSinceAutoBackup < COINJOIN_KEYS_THRESHOLD_WARNING) {
|
||||||
|
warning_msg = "WARNING: keypool is almost depleted!";
|
||||||
|
}
|
||||||
|
}
|
||||||
|
obj.pushKV("warnings", warning_msg);
|
||||||
#endif // ENABLE_WALLET
|
#endif // ENABLE_WALLET
|
||||||
|
|
||||||
return obj;
|
return obj;
|
||||||
|
Loading…
Reference in New Issue
Block a user