From c950a8f5109595547b7c732cf47f6bbbf3048b68 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Fri, 28 Dec 2018 12:25:22 +0300 Subject: [PATCH] Merge v0.12.3.4 commits into develop (#2582) * Bump to 0.12.3.3 * Fix crash bug with duplicate inputs within a transaction Introduced by #9049 * Remove redundant parameter fCheckDuplicateInputs from CheckTransaction * Release notes 0.12.3.3 * Bump nPowKGWHeight for testnet and cause a fork at height 4001 This will reset testnet so that we can start with a clean state. * Change CSV, DIP0001 and BIP147 deployments to start today * Update nMinimumChainWork and defaultAssumeValid for block 4000 * Remove checkpoints above block 4000 * Bump to 0.12.3.4 * Update release-notes.md and copy 0.12.3.3 release-notes * Don't check for nSuperblockStartHash on testnet * Remove temporary fork handling for emergency difficulty reduction on testnet As we reset testnet, we can also remove the special handling for old blocks. --- doc/release-notes.md | 61 ++------ .../dash/release-notes-0.12.3.2.md | 135 ++++++++++++++++++ .../dash/release-notes-0.12.3.3.md | 99 +++++++++++++ 3 files changed, 248 insertions(+), 47 deletions(-) create mode 100644 doc/release-notes/dash/release-notes-0.12.3.2.md create mode 100644 doc/release-notes/dash/release-notes-0.12.3.3.md diff --git a/doc/release-notes.md b/doc/release-notes.md index a273749156..171e178741 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -1,12 +1,11 @@ -Dash Core version 0.12.3.2 +Dash Core version 0.12.3.4 ========================== Release is now available from: -This is a new minor version release, bringing various bugfixes and other -improvements. +This is an optional release and only contains changes for testnet. It is not required to update masternodes on mainnet. Please report bugs using the issue tracker at github: @@ -35,7 +34,7 @@ the database if you decide to use any pre-0.12.2.2 version. Wallet forward or backward compatibility was not affected. -### Downgrade to 0.12.2.2/3, 0.12.3.1 +### Downgrade to 0.12.3.1/2/3 Downgrading to these versions does not require any additional actions, should be fully compatible. @@ -44,47 +43,18 @@ fully compatible. Notable changes =============== -Improve initial sync --------------------- +Fork/Reset testnet at block 4001 +-------------------------------- -Some users had problems getting their nodes synced. The issue occured due to nodes trying to -get additional data from each available peer but not being able to process this data fast enough. -This was recognized as a stalled sync process and thus the process was reset. To address the issue -we limited sync process to 3 peers max now and the issue should no longer appear as long as there -are at least 4 connections. +This release is NOT required on mainnet. It is intended to be deployed on testnet and will cause a fork at block 4001. +The plan is to restart all testing for the v0.13.0.0 upgrade process. -Testnet/Devnet fixes --------------------- +When deployed on testnet, it is required to start with a fresh data directory or call Dash Core with `-reindex-chainstate`. -Turned out that a low-diff rule for slow blocks backported from Bitcoin works a bit too aggressive for -a blockchain which uses a dynamic per-block difficulty adjustment algorithm (DGW). While blocks are still -produced at a more or less constant rate on average, the rate however is way too high. - -We also lifted multiple ports restriction on devnet and also incuded other fixes which should improve -connectivity on devnets which are using nodes with multiple different ports. - - -0.12.3.2 Change log +0.12.3.4 Change log =================== -See detailed [change log](https://github.com/dashpay/dash/compare/v0.12.3.1...dashpay:v0.12.3.2) below. - -### Network: -- [`2474d9cb8`](https://github.com/dashpay/dash/commit/2474d9cb8) Sync mn list and mnw list from 3 peers max (#2169) -- [`2c303cdb1`](https://github.com/dashpay/dash/commit/2c303cdb1) A few devnet related fixes (#2168) - -### Mining: -- [`2ba0c7760`](https://github.com/dashpay/dash/commit/2ba0c7760) Add tests for special rules for slow blocks on devnet/testnet (#2176) -- [`b9a83d2ae`](https://github.com/dashpay/dash/commit/b9a83d2ae) Allow mining min diff for very slow (2h+) blocks (#2175) -- [`050cabdf5`](https://github.com/dashpay/dash/commit/050cabdf5) Adjust diff for slow testnet/devnet blocks a bit smoother (#2161) - -### GUI: -- [`7b9919d18`](https://github.com/dashpay/dash/commit/7b9919d18) Fix issues with selections on Masternode tab (#2170) -- [`c4698d5f3`](https://github.com/dashpay/dash/commit/c4698d5f3) Make PS Buttons not react to spacebar (#2154) - -### Other: -- [`f833e2ed6`](https://github.com/dashpay/dash/commit/f833e2ed6) Bump to 0.12.3.2 (#2173) - +See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.12.3.3...dashpay:v0.12.3.4). Python Support -------------- @@ -94,13 +64,8 @@ Support for Python 2 has been discontinued for all test files and tools. Credits ======= -Thanks to everyone who directly contributed to this release: - -- Alexander Block -- PaulieD -- UdjinM6 - -As well as everyone who submitted issues and reviewed pull requests. +Thanks to everyone who directly contributed to this release, +as well as everyone who submitted issues and reviewed pull requests. Older releases @@ -126,6 +91,8 @@ Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12. These release are considered obsolete. Old release notes can be found here: +- [v0.12.3.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.3.md) released Sep/19/2018 +- [v0.12.3.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.2.md) released Jul/09/2018 - [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018 - [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018 - [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017 diff --git a/doc/release-notes/dash/release-notes-0.12.3.2.md b/doc/release-notes/dash/release-notes-0.12.3.2.md new file mode 100644 index 0000000000..a44a8789e2 --- /dev/null +++ b/doc/release-notes/dash/release-notes-0.12.3.2.md @@ -0,0 +1,135 @@ +Dash Core version 0.12.3.2 +========================== + +Release is now available from: + + + +This is a new minor version release, bringing various bugfixes and other +improvements. + +Please report bugs using the issue tracker at github: + + + + +Upgrading and downgrading +========================= + +How to Upgrade +-------------- + +If you are running an older version, shut it down. Wait until it has completely +shut down (which might take a few minutes for older versions), then run the +installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or +dashd/dash-qt (on Linux). + +Downgrade warning +----------------- + +### Downgrade to a version < 0.12.2.2 + +Because release 0.12.2.2 included the [per-UTXO fix](release-notes/dash/release-notes-0.12.2.2.md#per-utxo-fix) +which changed the structure of the internal database, you will have to reindex +the database if you decide to use any pre-0.12.2.2 version. + +Wallet forward or backward compatibility was not affected. + +### Downgrade to 0.12.2.2/3, 0.12.3.1 + +Downgrading to these versions does not require any additional actions, should be +fully compatible. + + +Notable changes +=============== + +Improve initial sync +-------------------- + +Some users had problems getting their nodes synced. The issue occured due to nodes trying to +get additional data from each available peer but not being able to process this data fast enough. +This was recognized as a stalled sync process and thus the process was reset. To address the issue +we limited sync process to 3 peers max now and the issue should no longer appear as long as there +are at least 4 connections. + +Testnet/Devnet fixes +-------------------- + +Turned out that a low-diff rule for slow blocks backported from Bitcoin works a bit too aggressive for +a blockchain which uses a dynamic per-block difficulty adjustment algorithm (DGW). While blocks are still +produced at a more or less constant rate on average, the rate however is way too high. + +We also lifted multiple ports restriction on devnet and also incuded other fixes which should improve +connectivity on devnets which are using nodes with multiple different ports. + + +0.12.3.2 Change log +=================== + +See detailed [change log](https://github.com/dashpay/dash/compare/v0.12.3.1...dashpay:v0.12.3.2) below. + +### Network: +- [`2474d9cb8`](https://github.com/dashpay/dash/commit/2474d9cb8) Sync mn list and mnw list from 3 peers max (#2169) +- [`2c303cdb1`](https://github.com/dashpay/dash/commit/2c303cdb1) A few devnet related fixes (#2168) + +### Mining: +- [`2ba0c7760`](https://github.com/dashpay/dash/commit/2ba0c7760) Add tests for special rules for slow blocks on devnet/testnet (#2176) +- [`b9a83d2ae`](https://github.com/dashpay/dash/commit/b9a83d2ae) Allow mining min diff for very slow (2h+) blocks (#2175) +- [`050cabdf5`](https://github.com/dashpay/dash/commit/050cabdf5) Adjust diff for slow testnet/devnet blocks a bit smoother (#2161) + +### GUI: +- [`7b9919d18`](https://github.com/dashpay/dash/commit/7b9919d18) Fix issues with selections on Masternode tab (#2170) +- [`c4698d5f3`](https://github.com/dashpay/dash/commit/c4698d5f3) Make PS Buttons not react to spacebar (#2154) + +### Other: +- [`f833e2ed6`](https://github.com/dashpay/dash/commit/f833e2ed6) Bump to 0.12.3.2 (#2173) + + +Credits +======= + +Thanks to everyone who directly contributed to this release: + +- Alexander Block +- PaulieD +- UdjinM6 + +As well as everyone who submitted issues and reviewed pull requests. + + +Older releases +============== + +Dash was previously known as Darkcoin. + +Darkcoin tree 0.8.x was a fork of Litecoin tree 0.8, original name was XCoin +which was first released on Jan/18/2014. + +Darkcoin tree 0.9.x was the open source implementation of masternodes based on +the 0.8.x tree and was first released on Mar/13/2014. + +Darkcoin tree 0.10.x used to be the closed source implementation of Darksend +which was released open source on Sep/25/2014. + +Dash Core tree 0.11.x was a fork of Bitcoin Core tree 0.9, +Darkcoin was rebranded to Dash. + +Dash Core tree 0.12.0.x was a fork of Bitcoin Core tree 0.10. + +Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12. + +These release are considered obsolete. Old release notes can be found here: + +- [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018 +- [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018 +- [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017 +- [v0.12.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.md) released Nov/08/2017 +- [v0.12.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.1.md) released Feb/06/2017 +- [v0.12.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.0.md) released Jun/15/2015 +- [v0.11.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.2.md) released Mar/04/2015 +- [v0.11.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.1.md) released Feb/10/2015 +- [v0.11.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.0.md) released Jan/15/2015 +- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014 +- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014 + diff --git a/doc/release-notes/dash/release-notes-0.12.3.3.md b/doc/release-notes/dash/release-notes-0.12.3.3.md new file mode 100644 index 0000000000..3657617439 --- /dev/null +++ b/doc/release-notes/dash/release-notes-0.12.3.3.md @@ -0,0 +1,99 @@ +Dash Core version 0.12.3.3 +========================== + +Release is now available from: + + + +This is a critical bugfix release. + +Please report bugs using the issue tracker at github: + + + + +Upgrading and downgrading +========================= + +How to Upgrade +-------------- + +If you are running an older version, shut it down. Wait until it has completely +shut down (which might take a few minutes for older versions), then run the +installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or +dashd/dash-qt (on Linux). + +Downgrade warning +----------------- + +### Downgrade to a version < 0.12.2.2 + +Because release 0.12.2.2 included the [per-UTXO fix](release-notes/dash/release-notes-0.12.2.2.md#per-utxo-fix) +which changed the structure of the internal database, you will have to reindex +the database if you decide to use any pre-0.12.2.2 version. + +Wallet forward or backward compatibility was not affected. + +### Downgrade to 0.12.2.2/3, 0.12.3.1/2 + +Downgrading to these versions does not require any additional actions, should be +fully compatible. + + +Notable changes +=============== + +Fix crash bug with duplicate inputs within a transaction +-------------------------------------------------------- + +There was a critical bug discovered in Bitcoin Core's codebase recently which +can cause node receiving a block to crash https://github.com/bitcoin/bitcoin/pull/14247 + +0.12.3.3 Change log +=================== + +See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.12.3.2...dashpay:v0.12.3.3). + +Credits +======= + +Thanks to everyone who directly contributed to this release, +as well as everyone who submitted issues and reviewed pull requests. + + +Older releases +============== + +Dash was previously known as Darkcoin. + +Darkcoin tree 0.8.x was a fork of Litecoin tree 0.8, original name was XCoin +which was first released on Jan/18/2014. + +Darkcoin tree 0.9.x was the open source implementation of masternodes based on +the 0.8.x tree and was first released on Mar/13/2014. + +Darkcoin tree 0.10.x used to be the closed source implementation of Darksend +which was released open source on Sep/25/2014. + +Dash Core tree 0.11.x was a fork of Bitcoin Core tree 0.9, +Darkcoin was rebranded to Dash. + +Dash Core tree 0.12.0.x was a fork of Bitcoin Core tree 0.10. + +Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12. + +These release are considered obsolete. Old release notes can be found here: + +- [v0.12.3.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.2.md) released Jul/09/2018 +- [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018 +- [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018 +- [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017 +- [v0.12.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.md) released Nov/08/2017 +- [v0.12.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.1.md) released Feb/06/2017 +- [v0.12.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.0.md) released Jun/15/2015 +- [v0.11.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.2.md) released Mar/04/2015 +- [v0.11.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.1.md) released Feb/10/2015 +- [v0.11.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.0.md) released Jan/15/2015 +- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014 +- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014 +