sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 20:12:57 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat: update some asserts related to CreditPool in consensus code to exceptions

Browse Source
This commit is contained in:
Konstantin Akimov 2024-10-28 22:20:31 +07:00
parent 877aa08144
commit c97f5f5ca5
No known key found for this signature in database
GPG Key ID: 2176C4A5D01EA524
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/evo/creditpool.cpp
View File

@ -134,9 +134,13 @@ CCreditPool CCreditPoolManager::ConstructCreditPool(const CBlockIndex* const blo
if (!block) { if (!block) {
// If reading of previous block is not successfully, but // If reading of previous block is not successfully, but
// prev contains credit pool related data, something strange happened // prev contains credit pool related data, something strange happened
assert(prev.locked == 0); if (prev.locked != 0) {
assert(prev.indexes.IsEmpty()); throw std::runtime_error(strprintf("Failed to create CreditPool but previous block has value"));
}
if (!prev.indexes.IsEmpty()) {
throw std::runtime_error(
strprintf("Failed to create CreditPool but asset unlock transactions already mined"));
}
CCreditPool emptyPool; CCreditPool emptyPool;
AddToCache(block_index->GetBlockHash(), block_index->nHeight, emptyPool); AddToCache(block_index->GetBlockHash(), block_index->nHeight, emptyPool);
return emptyPool; return emptyPool;
@ -184,9 +188,7 @@ CCreditPool CCreditPoolManager::ConstructCreditPool(const CBlockIndex* const blo
currentLimit = std::min(currentLimit, LimitAmountHigh - latelyUnlocked); currentLimit = std::min(currentLimit, LimitAmountHigh - latelyUnlocked);
} }
assert(currentLimit >= 0); if (currentLimit != 0 || latelyUnlocked > 0 || locked > 0) {
if (currentLimit > 0 || latelyUnlocked > 0 || locked > 0) {
LogPrint(BCLog::CREDITPOOL, /* Continued */ LogPrint(BCLog::CREDITPOOL, /* Continued */
"CCreditPoolManager: asset unlock limits on height: %d locked: %d.%08d limit: %d.%08d " "CCreditPoolManager: asset unlock limits on height: %d locked: %d.%08d limit: %d.%08d "
"unlocked-in-window: %d.%08d\n", "unlocked-in-window: %d.%08d\n",
@ -194,6 +196,11 @@ CCreditPool CCreditPoolManager::ConstructCreditPool(const CBlockIndex* const blo
latelyUnlocked / COIN, latelyUnlocked % COIN); latelyUnlocked / COIN, latelyUnlocked % COIN);
} }
if (currentLimit < 0) {
throw std::runtime_error(
strprintf("Negative limit for CreditPool: %d.%08d\n", currentLimit / COIN, currentLimit % COIN));
}
CCreditPool pool{locked, currentLimit, latelyUnlocked, indexes}; CCreditPool pool{locked, currentLimit, latelyUnlocked, indexes};
AddToCache(block_index->GetBlockHash(), block_index->nHeight, pool); AddToCache(block_index->GetBlockHash(), block_index->nHeight, pool);
return pool; return pool;