sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-24 11:32:46 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #6187: feat: fire up devnets by block 2 - 1/n

Browse Source 
c8f7c28ac8 docs: release notes for devnets fast fork activations (Konstantin Akimov)
2e1cd9c298 feat: quick assemble of devnets (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Many hard-forks have been delayed to block-300 on devnet to be compatible with existing devnets.

  Let's make a breaking changes (for devnet) to activate everything as fast as it ready, just from block 2.

  ## What was done?
  Set activation for all buried developments on devnet at the block 2 at the latest.

  ## How Has This Been Tested?
  Run new devnet - charlie - works as expected:
  ```
    "softforks": {
      "bip34": {
        "type": "buried",
        "active": true,
        "height": 1
      },
      "bip66": {
        "type": "buried",
        "active": true,
        "height": 1
      },
      "bip65": {
        "type": "buried",
        "active": true,
        "height": 1
      },
      "bip147": {
        "type": "buried",
        "active": true,
        "height": 1
      },
      "csv": {
        "type": "buried",
        "active": true,
        "height": 1
      },
      "dip0001": {
        "type": "buried",
        "active": true,
        "height": 2
      },
      "dip0003": {
        "type": "buried",
        "active": true,
        "height": 2
      },
      "dip0008": {
        "type": "buried",
        "active": true,
        "height": 2
      },
      "dip0020": {
        "type": "buried",
        "active": true,
        "height": 2
      },
      "dip0024": {
        "type": "buried",
        "active": true,
        "height": 2
      },
      "realloc": {
        "type": "buried",
        "active": true,
        "height": 2
      },
      "v19": {
        "type": "buried",
        "active": true,
        "height": 2
      },
  ...
  ```

  ## Breaking Changes
  Breaking changes on devnet: all buried forks are activated at once

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    utACK c8f7c28ac8
  PastaPastaPasta:
    utACK c8f7c28ac8

Tree-SHA512: c7c13e52873b91d25e5502f1f4ad7c91d8f10ec8227dd2f93205d53091b13d7e7f169c022d0182306e8df0f8b9cd409a2d2b67d9023432d375da1750b4612e06
This commit is contained in:
pasta 2024-10-04 14:11:24 -05:00
commit cf1db67335
No known key found for this signature in database
GPG Key ID: E2F3D7916E722D38
2 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/release-notes-6187.md Normal file
View File

@ -0,0 +1,3 @@
## Devnet Breaking Changes
`BRR` (`realloc`), `DIP0020`, `DIP0024`, `V19`, `V20` and `MN_R` hardforks are activated at block 2 instead of block 300 on devnets now. Please note that this is a breaking change so you will no longer be able to sync on devnets created with earlier Dash Core versions and vice versa.

26
src/chainparams.cpp
View File

@ -524,24 +524,24 @@ public:
consensus.nGovernanceMinQuorum = 1;
consensus.nGovernanceFilterElements = 500;
consensus.nMasternodeMinimumConfirmations = 1;
consensus.BIP34Height = 1; // BIP34 activated immediately on devnet
consensus.BIP65Height = 1; // BIP65 activated immediately on devnet
consensus.BIP66Height = 1; // BIP66 activated immediately on devnet
consensus.BIP147Height = 1; // BIP147 activated immediately on devnet
consensus.CSVHeight = 1; // BIP68 activated immediately on devnet
consensus.BIP34Height = 1; // BIP34 activated immediately on devnet
consensus.BIP65Height = 1; // BIP65 activated immediately on devnet
consensus.BIP66Height = 1; // BIP66 activated immediately on devnet
consensus.BIP147Height = 1; // BIP147 activated immediately on devnet
consensus.CSVHeight = 1; // BIP68 activated immediately on devnet
consensus.DIP0001Height = 2; // DIP0001 activated immediately on devnet
consensus.DIP0003Height = 2; // DIP0003 activated immediately on devnet
consensus.DIP0003EnforcementHeight = 2; // DIP0003 activated immediately on devnet
consensus.DIP0003EnforcementHash = uint256();
consensus.DIP0008Height = 2; // DIP0008 activated immediately on devnet
consensus.BRRHeight = 300;
consensus.DIP0020Height = 300;
consensus.DIP0024Height = 300;
consensus.DIP0024QuorumsHeight = 300;
consensus.V19Height = 300;
consensus.V20Height = 300;
consensus.MN_RRHeight = 300;
consensus.MinBIP9WarningHeight = 300 + 2016; // mn_rr activation height + miner confirmation window
consensus.BRRHeight = 2; // BRR (realloc) activated immediately on devnet
consensus.DIP0020Height = 2; // DIP0020 activated immediately on devnet
consensus.DIP0024Height = 2; // DIP0024 activated immediately on devnet
consensus.DIP0024QuorumsHeight = 2; // DIP0024 activated immediately on devnet
consensus.V19Height = 2; // V19 activated immediately on devnet
consensus.V20Height = 2; // V20 activated immediately on devnet
consensus.MN_RRHeight = 2; // MN_RR activated immediately on devnet
consensus.MinBIP9WarningHeight = 2 + 2016; // v19 activation height + miner confirmation window
consensus.powLimit = uint256S("7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"); // ~uint256(0) >> 1
consensus.nPowTargetTimespan = 24 * 60 * 60; // Dash: 1 day
consensus.nPowTargetSpacing = 2.5 * 60; // Dash: 2.5 minutes