sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-26 04:22:55 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: add missing client's argument parsing for RPC commands

Browse Source
This commit is contained in:
Konstantin Akimov 2024-07-12 03:20:15 +07:00
parent 37bd4009c1
commit d3e181f516
No known key found for this signature in database
GPG Key ID: 2176C4A5D01EA524
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/rpc/client.cpp
View File

@ -225,6 +225,10 @@ static const CRPCConvertParam vRPCConvertParams[] =
{ "getnodeaddresses", 0, "count"}, { "getnodeaddresses", 0, "count"},
{ "addpeeraddress", 1, "port"}, { "addpeeraddress", 1, "port"},
{ "stop", 0, "wait" }, { "stop", 0, "wait" },
{ "verifychainlock", 2, "blockHeight" },
{ "verifyislock", 3, "maxHeight" },
{ "submitchainlock", 2, "blockHeight" },
{ "mnauth", 0, "nodeId" },
}; };
// clang-format on // clang-format on

2
src/rpc/misc.cpp
View File

@ -617,7 +617,7 @@ static RPCHelpMan mnauth()
if (!Params().MineBlocksOnDemand()) if (!Params().MineBlocksOnDemand())
throw std::runtime_error("mnauth for regression testing (-regtest mode) only"); throw std::runtime_error("mnauth for regression testing (-regtest mode) only");
int nodeId = ParseInt64V(request.params[0], "nodeId"); int64_t nodeId = request.params[0].get_int64();
uint256 proTxHash = ParseHashV(request.params[1], "proTxHash"); uint256 proTxHash = ParseHashV(request.params[1], "proTxHash");
if (proTxHash.IsNull()) { if (proTxHash.IsNull()) {
throw JSONRPCError(RPC_INVALID_PARAMETER, "proTxHash invalid"); throw JSONRPCError(RPC_INVALID_PARAMETER, "proTxHash invalid");

6
src/rpc/quorums.cpp
View File

@ -974,7 +974,7 @@ static RPCHelpMan verifychainlock()
} }
nBlockHeight = pIndex->nHeight; nBlockHeight = pIndex->nHeight;
} else { } else {
nBlockHeight = ParseInt32V(request.params[2], "blockHeight"); nBlockHeight = request.params[2].get_int();
LOCK(cs_main); LOCK(cs_main);
if (nBlockHeight < 0) { if (nBlockHeight < 0) {
throw JSONRPCError(RPC_INVALID_PARAMETER, "Block height out of range"); throw JSONRPCError(RPC_INVALID_PARAMETER, "Block height out of range");
@ -1040,7 +1040,7 @@ static RPCHelpMan verifyislock()
int maxHeight{-1}; int maxHeight{-1};
if (!request.params[3].isNull()) { if (!request.params[3].isNull()) {
maxHeight = ParseInt32V(request.params[3], "maxHeight"); maxHeight = request.params[3].get_int();
} }
int signHeight; int signHeight;
@ -1094,7 +1094,7 @@ static RPCHelpMan submitchainlock()
{ {
const uint256 nBlockHash(ParseHashV(request.params[0], "blockHash")); const uint256 nBlockHash(ParseHashV(request.params[0], "blockHash"));
const int nBlockHeight = ParseInt32V(request.params[2], "blockHeight"); const int nBlockHeight = request.params[2].get_int();
if (nBlockHeight <= 0) { if (nBlockHeight <= 0) {
throw JSONRPCError(RPC_INVALID_PARAMETER, "invalid block height"); throw JSONRPCError(RPC_INVALID_PARAMETER, "invalid block height");
} }