sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #16484: doc: update labels in CONTRIBUTING.md

Browse Source 
faa88d0b5c7f6e317d0e35daef28d320801f1bb5 doc: update labels in CONTRIBUTING.md (MarcoFalke)

Pull request description:

  None of the examples in the "trivial" area are acceptable pull requests, unless they are acceptable in a different area (like "doc" or "log").

  Fix that by removing the "trivial" area.

ACKs for top commit:
  jonatack:
    ACK faa88d0b5c7f6e317d0e35daef28d320801f1bb5
  fanquake:
    ACK faa88d0b5c7f6e317d0e35daef28d320801f1bb5 - agree that trivial was pretty useless and that the meaning was unclear. Other changes look fine. Surprised the white space linter hasn't been having a field day in this file.

Tree-SHA512: 6208bcc7c84ad0ca6aeaa2de1901c9da8971aac332b5e7a1194ea7b24fb2d887f988aa22fdfa818e89cbcfd8cb8595ce312525f88c81c5ade484fd7c9bd13d1b
This commit is contained in:
fanquake 2019-07-30 11:40:39 +08:00 committed by munkybooty
parent 3f17cc9dd3
commit dbdfa1b3d0
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
CONTRIBUTING.md
View File

@ -61,21 +61,15 @@ The title of the pull request should be prefixed by the component or area that
the pull request affects. Valid areas as: the pull request affects. Valid areas as:
- *Consensus* for changes to consensus critical code - *Consensus* for changes to consensus critical code
- *Docs* for changes to the documentation - *Doc* for changes to the documentation
- *Qt* for changes to dash-qt - *Qt* for changes to dash-qt
- *Log* Changes to log messages
- *Mining* for changes to the mining code - *Mining* for changes to the mining code
- *Net* or *P2P* for changes to the peer-to-peer network code - *Net* or *P2P* for changes to the peer-to-peer network code
- *Refactor* for structural changes that do not change behavior
- *RPC/REST/ZMQ* for changes to the RPC, REST or ZMQ APIs - *RPC/REST/ZMQ* for changes to the RPC, REST or ZMQ APIs
- *Scripts and tools* for changes to the scripts and tools - *Scripts and tools* for changes to the scripts and tools
- *Tests* for changes to the unit tests or QA tests - *Test* for changes to the unit tests or QA tests
- *Trivial* should **only** be used for PRs that do not change generated
executable code. Notably, refactors (change of function arguments and code
reorganization) and changes in behavior should **not** be marked as trivial.
Examples of trivial PRs are changes to:
- comments
- whitespace
- variable names
- logging and messages
- *Utils and libraries* for changes to the utils and libraries - *Utils and libraries* for changes to the utils and libraries
- *Wallet* for changes to the wallet code - *Wallet* for changes to the wallet code
@ -84,7 +78,7 @@ Examples:
Consensus: Add new opcode for BIP-XXXX OP_CHECKAWESOMESIG Consensus: Add new opcode for BIP-XXXX OP_CHECKAWESOMESIG
Net: Automatically create hidden service, listen on Tor Net: Automatically create hidden service, listen on Tor
Qt: Add feed bump button Qt: Add feed bump button
Trivial: Fix typo in init.cpp Log: Fix typo in log message
Note that translations should not be submitted as pull requests, please see Note that translations should not be submitted as pull requests, please see
[Translation Process](https://github.com/dashpay/dash/blob/master/doc/translation_process.md) [Translation Process](https://github.com/dashpay/dash/blob/master/doc/translation_process.md)