From e2f58f421b1a6e360bbf7efdfbba398918ce19d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Barbosa?= <joao.paulo.barbosa@gmail.com>
Date: Thu, 19 Apr 2018 14:44:34 +0100
Subject: [PATCH] wallet: Make vpwallets usage thread safe

---
 src/wallet/wallet.cpp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
index ad3dd4cd2c..6e0f49f136 100644
--- a/src/wallet/wallet.cpp
+++ b/src/wallet/wallet.cpp
@@ -34,10 +34,12 @@
 
 #include <boost/algorithm/string/replace.hpp>
 
-static std::vector<CWallet*> vpwallets;
+static CCriticalSection cs_wallets;
+static std::vector<CWallet*> vpwallets GUARDED_BY(cs_wallets);
 
 bool AddWallet(CWallet* wallet)
 {
+    LOCK(cs_wallets);
     assert(wallet);
     std::vector<CWallet*>::const_iterator i = std::find(vpwallets.begin(), vpwallets.end(), wallet);
     if (i != vpwallets.end()) return false;
@@ -47,6 +49,7 @@ bool AddWallet(CWallet* wallet)
 
 bool RemoveWallet(CWallet* wallet)
 {
+    LOCK(cs_wallets);
     assert(wallet);
     std::vector<CWallet*>::iterator i = std::find(vpwallets.begin(), vpwallets.end(), wallet);
     if (i == vpwallets.end()) return false;
@@ -56,16 +59,19 @@ bool RemoveWallet(CWallet* wallet)
 
 bool HasWallets()
 {
+    LOCK(cs_wallets);
     return !vpwallets.empty();
 }
 
 std::vector<CWallet*> GetWallets()
 {
+    LOCK(cs_wallets);
     return vpwallets;
 }
 
 CWallet* GetWallet(const std::string& name)
 {
+    LOCK(cs_wallets);
     for (CWallet* wallet : vpwallets) {
         if (wallet->GetName() == name) return wallet;
     }