From e6f19e77600a95f331ebb12320ae764a52ee47ed Mon Sep 17 00:00:00 2001 From: fanquake Date: Wed, 13 Dec 2023 11:21:35 +0000 Subject: [PATCH] Merge bitcoin/bitcoin#29068: test: Actually fail when a python unit test fails fa0534d7e47d44428d3f9dea6d2f6b8e86df22d4 test: Actually fail when a python unit test fails (MarcoFalke) Pull request description: Currently python unit test failures are ignored. Fix this. ACKs for top commit: theStack: ACK fa0534d7e47d44428d3f9dea6d2f6b8e86df22d4 BrandonOdiwuor: ACK fa0534d7e47d44428d3f9dea6d2f6b8e86df22d4 Tree-SHA512: c136be4c8d861d966f380e04d5d14b711b90c4011101302dae1332496e493207c5c673927586ed35b02b61a0b050bf45053a31e6ff766ec52f1d054caf0985e2 --- test/functional/test_runner.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py index 7573bd7df1..0527e22050 100755 --- a/test/functional/test_runner.py +++ b/test/functional/test_runner.py @@ -551,8 +551,7 @@ def run_tests(*, test_list, src_dir, build_dir, tmpdir, jobs=1, attempts=1, enab test_framework_tests.addTest(unittest.TestLoader().loadTestsFromName("test_framework.{}".format(module))) result = unittest.TextTestRunner(verbosity=1, failfast=True).run(test_framework_tests) if not result.wasSuccessful(): - logging.debug("Early exiting after failure in TestFramework unit tests") - sys.exit(False) + sys.exit("Early exiting after failure in TestFramework unit tests") tests_dir = src_dir + '/test/functional/'