Fix non-standard disconnected transactions causing mempool orphans

This commit is contained in:
Pieter Wuille 2013-08-02 02:47:22 +02:00 committed by Pieter Wuille
parent 4323bfeafd
commit f0784ac470

View File

@ -973,8 +973,6 @@ bool CTxMemPool::remove(const CTransaction &tx, bool fRecursive)
{ {
LOCK(cs); LOCK(cs);
uint256 hash = tx.GetHash(); uint256 hash = tx.GetHash();
if (mapTx.count(hash))
{
if (fRecursive) { if (fRecursive) {
for (unsigned int i = 0; i < tx.vout.size(); i++) { for (unsigned int i = 0; i < tx.vout.size(); i++) {
std::map<COutPoint, CInPoint>::iterator it = mapNextTx.find(COutPoint(hash, i)); std::map<COutPoint, CInPoint>::iterator it = mapNextTx.find(COutPoint(hash, i));
@ -982,6 +980,8 @@ bool CTxMemPool::remove(const CTransaction &tx, bool fRecursive)
remove(*it->second.ptx, true); remove(*it->second.ptx, true);
} }
} }
if (mapTx.count(hash))
{
BOOST_FOREACH(const CTxIn& txin, tx.vin) BOOST_FOREACH(const CTxIn& txin, tx.vin)
mapNextTx.erase(txin.prevout); mapNextTx.erase(txin.prevout);
mapTx.erase(hash); mapTx.erase(hash);
@ -2083,7 +2083,8 @@ bool SetBestChain(CValidationState &state, CBlockIndex* pindexNew)
BOOST_FOREACH(CTransaction& tx, vResurrect) { BOOST_FOREACH(CTransaction& tx, vResurrect) {
// ignore validation errors in resurrected transactions // ignore validation errors in resurrected transactions
CValidationState stateDummy; CValidationState stateDummy;
mempool.accept(stateDummy, tx, false, NULL); if (!mempool.accept(stateDummy, tx, false, NULL))
mempool.remove(tx, true);
} }
// Delete redundant memory transactions that are in the connected branch // Delete redundant memory transactions that are in the connected branch